CBIIT / nci-ctd2-dashboard-tmpl-helper

NCI CTD^2 Dashboard Template Helper
3 stars 1 forks source link

Allow comma in observation values #33

Closed vdancik closed 5 years ago

vdancik commented 6 years ago

A comma in observation value (needed for some compound names, e.g. 1S,3R-RSL3) appears to break the content of submitted data.

kcs3 commented 6 years ago

This could affect various aspects of the Dashboard such as stable URLs. Change the comma to a dash in the stable URL?

kcs3 commented 6 years ago

The Dashboard already handles all such characters as part of the stable URL rules. So this change applies to and affects only the Submission Builder.

kcs3 commented 6 years ago

Code was rewritten to handle commas and double quotes.

Tested submission with commas and quotes, seems to be all ok, they appear in the generated spreadsheet.