Open kcs3 opened 4 years ago
test6.zip recreate a test case based on the description of the Word document
test7.zip create the test case 7 according to the Word document
Test 8 in the Word document: The reason that the submission name is reported instead of the submission date when both are missing is that the correct submission name is supposed to be the concatenation of date and the template name, and the submission name is checked before the date is checked.
Sorry, here is my original test file mentioned above.
Test case 6 is now correctly handled, the mismatch in template names is reported.
The action for test case 7 seems adequate, no further change needed at the moment.
We have decided to add explicit checking for missing values in required template fields during validation. This is not a problem one would expect to see during validation of submission-helper created submissions, but could occur in submissions created outside the builder and then uploaded.
There are two files to check: In "dashboard-CV-per-template", check all fields have some non-empty value in them, except "story_title" which can be empty (we need to check if PI is required, think it is).
In the actual observation template, the required fields are: submission_name submission_date template_name
A few more results of removing the entries from specific fields in the observation template.
The most interesting result was that deleting the date caused the script to report an incorrect submission name, rather than that the date was missing:
Otherwise, I note that these types of errors do not show up in the downloaded error report, which is empty.
Submission Builder testing 6-8.docx