CBIIT / nci-ctd2-dashboard-tmpl-helper

NCI CTD^2 Dashboard Template Helper
3 stars 1 forks source link

validation failure caused by the Excel sheet name limit #51

Open zhouji2013 opened 4 years ago

zhouji2013 commented 4 years ago

The current validation process checks whether the template name (as entered in the spreadsheet) matches the sheet name. In fact, Excel sheet's name is limited to 31 characters while the template names are allowed to be longer. To avoid false alarm, the current checking needs to be loosened to accommodate the case when the sheet name is a truncated template name.

vdancik commented 4 years ago

Would not it be better to enforce 31-character limit for submission name on data entry?

zhouji2013 commented 4 years ago

Would not it be better to enforce 31-character limit for submission name on data entry?

I believe that there are many existing submission names longer than this. To implement your suggestion, we would need to change those names retrospectively.

zhouji2013 commented 3 years ago

Per Ken's recommendation, we enforce this limit here, but not for the existing submissions.

zhouji2013 commented 3 years ago

This is a test case for checking this limit test_51.zip