search

CBaquero / delta-enabled-crdts

Reference implementations of state-based CRDTs that offer deltas for all mutations.
Apache License 2.0
318 stars 36 forks source link

maybe improper join function on dotkernel? #2

Closed leifwalsh closed 8 years ago

leifwalsh commented 8 years ago

https://github.com/CBaquero/delta-enabled-crdts/blob/5f9565619d8c4b265863d39cadf4c07be921f485/delta-crdts.cc#L321 I think this should be && instead of ||? The way it is now, if one iterator dies then we stop examining the other one, so we'd lose data if there were new items later on in o, or we'd neglect to delete data if there was evidence that later items in this had been deleted.

leifwalsh commented 8 years ago

no I can't do boolean algebra, ignore me. ugh.