Not able to connect with mIRC

MattiSony commented 8 years ago

Hey, i've been trying to use this with mIRC but for some reason it wont connect. I also tried it with HexChat and Chatty which did work.

mIRC log:

127.0.0.1 CAP LS
127.0.0.1 PASS oauth:*********************
127.0.0.1 NICK Mattisony
127.0.0.1 USER mattisony 0 * :Matti Sony
127.0.0.1 QUIT :

TMoohI log:

[INFO] [general] TMoohI v0.0.5 (Build 308) loaded
[INFO] [general] Starting TMoohI server on port 6667 - CTRL+C to stop
[INFO] [websocket] WebSocketServer loading up!
[DEBUG] {"users": {}, "since": 1452119984.050469, "queue": 0, "build": {"projectname": "TMoohI", "data": {"version": "0.0.5", "hash": "5329c75d5ed0f3a7d19ec6f885af46bd", "build": 308}}}
[DEBUG] [websocket] Websocket connecting: tcp:127.0.0.1:64277
[DEBUG] [websocket] WebSocket connection open.
[DEBUG] [websocket] Websocket text message received: SETFILTER [{"level__ge":0},{"type":"stats"}]
[DEBUG] {"users": {}, "since": 1452119984.050469, "queue": 0, "build": {"projectname": "TMoohI", "data": {"version": "0.0.5", "hash": "5329c75d5ed0f3a7d19ec6f885af46bd", "build": 308}}}
[DEBUG] [client] Got raw client message from 127.0.0.1 (sock ID 1024): b'CAP LS\n'
[DEBUG] [client] Got raw client message from 127.0.0.1 (sock ID 1024): b'PASS oauth:(30)\nNICK Mattisony\nUSER mattisony 0 * :Matti Sony\n'
[DEBUG] {"users": {}, "since": 1452119984.050469, "queue": 0, "build": {"projectname": "TMoohI", "data": {"version": "0.0.5", "hash": "5329c75d5ed0f3a7d19ec6f885af46bd", "build": 308}}}
[DEBUG] [client] Got raw client message from 127.0.0.1 (sock ID 1024): b'QUIT :\n'
[ERROR] [exception] Traceback (most recent call last):
  File "C:\Testing\TMooohI\TMoohIManager.py", line 74, in disconnect
    client.user.clients.remove(client)
AttributeError: 'NoneType' object has no attribute 'clients'

[DEBUG] [client] Client 127.0.0.1 disconnected (sock ID 1024)

BTW I'm the one Quitting manually. After a couple seconds.

CBenni commented 8 years ago

It looks like MIRC is sending \n instead of \r\n, which is most likely the issue here. I have attempted to fix this by automatically detecting the line ending. It works in HexChat as before, I dont have mIRC to test however.

Please keep in mind that

this is a project in a very early stage and not meant for production use yet and
it was barely designed with client use in mind

Thank you for your feedback anyways :)

MattiSony commented 8 years ago

Working now, Thanks!

CBenni commented 8 years ago

Glad that fixed it, thanks for your throughout bug report!

CBenni / TMoohI

Not able to connect with mIRC #8