Add ConnectedServer Property to AprsIsClient

martelro commented 2 years ago

Description

As described in #120, a rotating address is often used to connect to an APRS-IS server; however, the actual connected server is not known to the user.

This change adds parsing to the AprsIsClient class to obtain the connected server and expose it as a property of the class.

Changes

Add nullable public property, ConnectedServer, to AprsIsClient
Add parsing logic via private method to obtain the server name from the connected server's login response and assign to ConnectedServer. If server name cannot be determined, the property value is set to null.
Private method also logs server name

Validation

Build passes
Created and passed unit tests
Ran locally at LogInformation visibility level to confirm server name is captured in property

martelro commented 2 years ago

Thank you for the kind review. Admittedly, I know some areas of C# better than others, but those will come with time and practice I hope!

I've pushed the updates, but please let me know if there's anything else. Thank you!

CBielstein commented 2 years ago

Commenting for my own sake: I did rerun the build task due to test timeout failures, but these were not related to this test. They are a known issue of our parallelism and such issues would be resolved by #125. With that in mind, I'm still merging this PR and we can fix #125 asap to ensure this doesn't happen again.

CBielstein / APRSsharp