search

CBielstein / APRSsharp

APRS# - Modern APRS software for the amateur radio community
MIT License
12 stars 5 forks source link

WeatherInfo parses out comment text #137

Closed martelro closed 1 year ago

martelro commented 2 years ago

Description

Trims the encoded weather measurements from the WeatherInfo info field object. Places the remaining "user" comment into the Comment property of the WeatherInfo object.

105

Changes

Add Comment property to WeatherInfo class. PositionInfo base class will still hold the untrimmed comment. Add logic in WeatherInfo to determine the consecutive portion of the comment which contains weather measurement data and strips that out of the comment. Weather measurements inside the comment will remain in the user comment and be evaluated as measurements. Update PrintPacket to display weather user comment Modify and create unit tests

Validation

Build passes Passed unit tests for encode/decode *Ran with live data and confirmed user comment captured as desired

CBielstein commented 2 years ago

Day job and "real life" have been busy. I see and appreciate this PR and will make an effort to review soon. Thank you!

martelro commented 1 year ago

No worries. Happy 4th!

On Fri, Jul 1, 2022 at 10:09 AM Cameron Bielstein @.***> wrote:

Day job and "real life" have been busy. I see and appreciate this PR and will make an effort to review soon. Thank you!

— Reply to this email directly, view it on GitHub https://github.com/CBielstein/APRSsharp/pull/137#issuecomment-1172552338, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIV3ZRQJSX54YGOVSXQZAJLVR4Q23ANCNFSM5ZJVBHOA . You are receiving this because you authored the thread.Message ID: @.***>