Switch TNC communication to bytes instead of strings - Githubissues

CBielstein / APRSsharp

APRS# - Modern APRS software for the amateur radio community

MIT License

12 stars 5 forks source link

Switch TNC communication to bytes instead of strings #153

Closed CBielstein closed 1 year ago

CBielstein commented 1 year ago

Description

Switches the KISS TNC logic away from sending strings and to sending bytes. Adds tests for TNC implementations.

Resolves #146

Changes

Introduces SendBytes method on TNCInterface and implementing classes
Update logic to call SendBytes instead of SendString (which now just wraps SendBytes as well)
Update TcpTNC to accept an ITcpConnection injected for testing
Add TcpTNC tests via refactored TNC tests

Validation

Manually ran with direwolf to test TCP connection
Tests all pass