search

CBielstein / APRSsharp

APRS# - Modern APRS software for the amateur radio community
MIT License
12 stars 5 forks source link

Default filter broken #162

Open ShawnStoddard opened 5 months ago

ShawnStoddard commented 5 months ago

In the process of creating a sample application I used most of the defaults defined in the APRS IS client class. The filter starts with the word "filter" but so does the line where it is used (in the SendLogin method). I removed the word "filter" from what I passed to the APRS IS client and things worked as expected. Can someone confirm, and if broken we'll make a fix.

CBielstein commented 5 months ago

Acknowledging this one as well. I'll report back after I get a chance to investigate. Thanks!

CBielstein commented 4 months ago

@ShawnStoddard Apologies for the delay. Day job and "real life" have just slowed down and now I can pick back up hobby work. 😃

On my machine, I don't see any issue in functionality...but it's certainly duplicating the word "filter" in the message it is sending, which is out of spec. I can imagine different server software may or may not handle that.

You mention you'd make a fix. If you mean a PR, I'd be happy to accept a PR (and should be much more responsive now). Possible fixes are:

  1. As you note, remove the "filter" word from where the default filter is defined at AprsIsClient.cs line 293
  2. Be smarter about prefixing the word "filter" on to the filter, perhaps? Only do so if the filter doesn't already start with the word filter. That would be in AprsIsClient.cs on line 219

Either should do it and I'm split on which approach is right, so I'm open to either at the moment, especially if you're sending a PR.

If you'd rather not send a PR, let me know and I can make a fix myself.