Add common build properties and StyleCop ruleset

CBielstein / APRSsharp

APRS# - Modern APRS software for the amateur radio community

MIT License

12 stars 5 forks source link

Add common build properties and StyleCop ruleset #19

Closed CBielstein closed 4 years ago

CBielstein commented 4 years ago

This PR adds common build properties and StyleCop ruleset to be included in all projects. This work is part of #8.

How verified:

Added references to KissIt.csproj and KissItUnitTests.csproj and ensured build was broken by ruleset violations.

CBielstein commented 4 years ago

@lugolven, I would love your eyes on this kind of change, if you have a few spare minutes. Any thoughts on how to do this more elegantly than remembering to import a common props file would be appreciated. Worst case, I guess I can make a GitHub Action to enforce that this is imported in all projects but I'm curious if you had other/better approaches to common build settings.

CBielstein commented 4 years ago

@lugolven, I don't see a strong reason for a SDK version lock for this project at this point. Let me know if you had some specific reason in mind.

CBielstein commented 4 years ago

I'm planning on not submitting this until @eddywine finishes the rename and version update tickets, to avoid merge conflicts with him. Specifically #6 #4 #5