CBielstein / APRSsharp

APRS# - Modern APRS software for the amateur radio community
MIT License
12 stars 5 forks source link

Enable static analyzers in AprsParser #39

Closed CBielstein closed 4 years ago

CBielstein commented 4 years ago

Description

This PR enables the rules in the root Directory.Build.props in the AprsParser directory. Most changes are just updates to analyzer warnings or suggestions. Part of #8.

In one place, this found a bug where a DateTime object was not correctly converted to UTC time. A new variable was declared for the conversion but it went unused. The unused variable was flagged and correcting the code to reference it caused unit test failures. This was followed up by a fix in the unit tests.

Changes

How verified