search

CBielstein / APRSsharp

APRS# - Modern APRS software for the amateur radio community
MIT License
12 stars 5 forks source link

Add an initial codeowners file #55

Closed CBielstein closed 3 years ago

CBielstein commented 3 years ago

Description

Code owners is a GitHub feature to require approval from specific individuals before PRs can be merged in to the main branch. Code owners are also automatically requested for reviews on PRs, which should help us ensure each PR adds each other in case we forget.

This PR adds an initial CODEOWNERS file which requires approval from either @CBielstein or @eddywine to merge code in to this repository.

Changes

Validation

lugolven commented 3 years ago

Have you used this feature before? Are you sure this is an “or“ and not an “and”? Or did I miss something on the documentation?

CBielstein commented 3 years ago

Have you used this feature before? Are you sure this is an “or“ and not an “and”? Or did I miss something on the documentation?

@lugolven I have used it before. This is an AND in that it will add both codeowners to the PR. However, it says nothing about required reviewers, which is handled by branch protection policy. My branch protection policy for main only requires a single reviewer.

lugolven commented 3 years ago

Have you used this feature before? Are you sure this is an “or“ and not an “and”? Or did I miss something on the documentation?

@lugolven I have used it before. This is an AND in that it will add both codeowners to the PR. However, it says nothing about required reviewers, which is handled by branch protection policy. My branch protection policy for main only requires a single reviewer.

I see, it’s adding you with an “and“ and configuration is making an “or“... GitHub is not making it on this one 😊