CBugDCoder / deltaglider

Add realistic hang gliders to Minetest
Other
4 stars 9 forks source link

Server crashes when exiting game while still on the glider #7

Closed d3wdrxp closed 1 month ago

d3wdrxp commented 2 years ago

This is the error according to the debug:

2022-05-22 09:48:36: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'glider' in callback luaentity_Step(): .../staging/worlds/world/worldmods/glider/init.lua:47: attempt to index local 'driver' (a nil value) 2022-05-22 09:48:36: ERROR[Main]: stack traceback: 2022-05-22 09:48:36: ERROR[Main]: ...staging/worlds/world/worldmods/glider/init.lua:47: in function <.../staging/worlds/world/worldmods/glider/init.lua:10>

insanity54 commented 2 years ago

Just saw a server crash due to this same thing. Not good that players can crash the server on demand as this can lead to protection bypass exploits.

2022-11-05 21:59:57: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'glider' in callback luaentity_Step(): /home/minetest/.minetest/mods/glider/init.lua:47: attempt to index local 'driver' (a nil value)

I came up with a patch and opened a pull request