Closed k7sleeper closed 10 years ago
Please, do not change indentation - add TimeOutError class and change just "new TimeOutError()". Then squash everything into one commit and force push.
OK, now?
The f8e8748 commit is great! Can you squash everything into just one commit or remove all commits except the last one and force push?
How can I do that?
$ git rebase -i HEAD~5
Then delete all lines except the line that contains f8e8748.
done
$ git push -u origin +master
done
I don't think so - I'm still seeing 5 commits instead of 1. :)
But now, it seems to be ok!
Sorry!
Excelent! Thanks!
Accepted with minor modifications:
TimeOutError.as
from spaces to tabs to match the rest of the projectTimeOutError
to TimeoutError
for naming consistency (i.e. originating method is timeout()
, not timeOut()
)Promise::timeout()
to reference TimeoutError
TimeoutError
to reference Promise::timeout()
Thank you!
When using Promise.timeout() you may want to differentiate between a promise time-out and other errors. To achive this I have added a TimeOutError class which Promise.timeout() use as rejection reason in case of a time-out.