CC-Archived / promise-as3

Promises/A+ compliant implementation in ActionScript 3.0
167 stars 52 forks source link

Promise.timeout() indicates time-out more precisely #41

Closed k7sleeper closed 10 years ago

k7sleeper commented 10 years ago

When using Promise.timeout() you may want to differentiate between a promise time-out and other errors. To achive this I have added a TimeOutError class which Promise.timeout() use as rejection reason in case of a time-out.

honzabrecka commented 10 years ago

Please, do not change indentation - add TimeOutError class and change just "new TimeOutError()". Then squash everything into one commit and force push.

k7sleeper commented 10 years ago

OK, now?

honzabrecka commented 10 years ago

The f8e8748 commit is great! Can you squash everything into just one commit or remove all commits except the last one and force push?

k7sleeper commented 10 years ago

How can I do that?

honzabrecka commented 10 years ago

$ git rebase -i HEAD~5 Then delete all lines except the line that contains f8e8748.

https://help.github.com/articles/about-git-rebase

k7sleeper commented 10 years ago

done

honzabrecka commented 10 years ago

$ git push -u origin +master

k7sleeper commented 10 years ago

done

honzabrecka commented 10 years ago

I don't think so - I'm still seeing 5 commits instead of 1. :)

k7sleeper commented 10 years ago

But now, it seems to be ok!

Sorry!

honzabrecka commented 10 years ago

Excelent! Thanks!

johnyanarella commented 10 years ago

Accepted with minor modifications:

Thank you!