CCAFS / MARLO

Managing Agricultural Research for Learning and Outcomes
GNU General Public License v3.0
8 stars 8 forks source link

[KT] (AICCRA) Develop Feedback Functionality #2429

Open kenjitm opened 2 years ago

kenjitm commented 2 years ago

Develop the feedback functionality in AICCRA according to the following template: https://docs.google.com/presentation/d/1AEW7EoDeNzOxVsoMZLDZqZoE9oHfWnA37_kXI0tuCx4/edit#slide=id.ge82d74f50f_0_5

kenjitm commented 2 years ago

It's possible to enable comments pop-up functionality for specific fields: image.png

And save comments for the selected field: image.png

kenjitm commented 2 years ago

image.png

MargaritaRamirez commented 2 years ago

@valviveros In meeting with Hector this morning, he requests the following change in the feedback status banner image.png

blue: No comments provided green: All comments tackled

valviveros commented 2 years ago

The requested change has been made. image

MargaritaRamirez commented 2 years ago

image.png image.png image.png image.png

In addition we will remove the icon at the right and colored the comments boxes

yecksin commented 2 years ago

image.png

About the May 26th meeting =>

It was discussed that there is no problem with the development time on the front end, since the MARLO logic is complex, so you must have a good level of abstraction and recursion. However, it can be improved by receiving adequate information in the services, e.g. that the "list" is iterable by default, since with many objects a more complex and time-consuming mapping must be done.

The only advice is to keep in mind good practices in "Clean Code" to be able to retake code when time goes by and reduce the technical debt in the future.

If "MARLO / AICCRA" is going to have more development time in the future with new features, it is better to resume the use of Vue.js as Sebastian did in the past. The advantage is also that you can hire people who work with Vue.js because we can reduce the use of MARCOS with FreeMarker and have a more dynamic code.

MargaritaRamirez commented 2 years ago

Message sent on June 8th, 2022

image.png

image.png

MargaritaRamirez commented 2 years ago

Replay from Laura (our comments in blue)

image.png