CCALI / a2jdat

This repo hosts the distributable production version of the A2J Document Assembly Tool (DAT). The document assembly tool is an optional piece of software used for producing pdf documents at the end of A2J Author Guided Interviews.
https://www.a2jauthor.org
Other
3 stars 1 forks source link

Node 16 steal upgrade #115

Closed tobiasnteireho closed 2 years ago

tobiasnteireho commented 2 years ago

upgrade steal to 2 and node 16. BREAKING CHANGE so moves to v8

tobiasnteireho commented 2 years ago

also pins volta

tobiasnteireho commented 2 years ago

also pins volta

is that a config prop for Volta saying to use that version of Node, or is a dependency of Volta being pinned to that version? Either way, I feel like we should have the caret there ^16.13.1 or at least the tilde to allow for patch updates.

It's a config prop for volta. My worry is that if we let it float with the caret, some of us might be out of sync or run into odd issues in development that are hard to explain. I don't think it would be desirable to have the build environment change in in between iterations. So far this has usually been a lessor issue but this way at least we all know we should be on a specific version which should make it easier to debug our environments. I'll have to look into if volta even supports the caret (it probably does).