search

CCALI / a2jdat

This repo hosts the distributable production version of the A2J Document Assembly Tool (DAT). The document assembly tool is an optional piece of software used for producing pdf documents at the end of A2J Author Guided Interviews.
https://www.a2jauthor.org
Other
3 stars 1 forks source link

Grouped variables on PDF templates fail without addendum label #54

Open mikemitchel opened 3 years ago

mikemitchel commented 3 years ago

When you have a text variable grouped with Ignore text overflow checked, but don't fill in an addendumLabel it will fail the assembly saying it's required in an error thrown in the DAT / Node console. If you add a label it will render/work, even though it should not care about a label.

Likely needs to be fixed in the patcher, or in code that calls the patchMultilineText() function call: https://github.com/CCALI/a2jdat/blob/950f801164b92321a6358c15d9db4b42d3cb2154/src/pdf/overlayer/patcher.js#L49

Breakpoint for checking the patches and if they have an addendumLabel provided and are of type multi-line-text is here: https://github.com/CCALI/a2jdat/blob/950f801164b92321a6358c15d9db4b42d3cb2154/src/pdf/overlayer/validate.js#L109

Sometimes other instances of grouped text variables have an addendumLabel set in the patch (matching the variable name) but don't show or render anything in the Variable modal. This may be a separate issue/edge case.

Attached sample of failing Variable setup: Screen Shot 2021-04-19 at 11 54 00 AM

mikemitchel commented 3 years ago

Small sample GI ,currently breaking (no addendumLabel but is grouped) Clip overflow group fail.zip