Closed chasenlehara closed 2 years ago
Previously, the logic inside assemble had two paths that did similar things: render text templates, set download headers, send the file, etc.
assemble
Now, the logic for getting the templates remains different, but rendering and sending the file is the same.
This also includes:
answers
combinePdfFiles
Part of https://github.com/CCALI/a2jdat/issues/94
one nitpick comment above, but :shipit:
Previously, the logic inside
assemble
had two paths that did similar things: render text templates, set download headers, send the file, etc.Now, the logic for getting the templates remains different, but rendering and sending the file is the same.
This also includes:
answers
is provided (it can be an empty object, but it has to be provided)combinePdfFiles
so it doesn’t create the writer when it’s only passed one PDF that won’t be modifiedPart of https://github.com/CCALI/a2jdat/issues/94