search

CCALI / a2jviewer

This is the repo for the A2J Viewer
https://www.a2jauthor.org
Other
5 stars 8 forks source link

Fix the styles in the document preview #193

Closed chasenlehara closed 2 years ago

chasenlehara commented 2 years ago

Previously, the styles from the app affected what’s in the document preview, so it wasn’t true to what the generated PDF would look like.

This is now resolved by inserting the document preview into its own iframe, where styles from the app won’t affect the preview HTML.

Fixes https://github.com/CCALI/a2jviewer/issues/181 Fixes https://github.com/CCALI/a2jviewer/issues/192

Previous

Screen Shot 2021-12-29 at 4 05 18 AM

Fixed

Screen Shot 2021-12-29 at 4 42 30 AM
chasenlehara commented 2 years ago

@tobiasnteireho I think this should be ok—if anything, it might be more secure than what I was doing before because it’s in an iframe. I’ll file an issue to investigate this more and run it by other Bitovians too who might have more experience.