search

CCALI / a2jviewer

This is the repo for the A2J Viewer
https://www.a2jauthor.org
Other
5 stars 8 forks source link

Advanced Navigation Panel hamburger menu "Open/Close" in reduced interface isn't translated #250

Open JessicaFrank opened 1 year ago

JessicaFrank commented 1 year ago

When the reduced user interface is enabled for the desktop viewer (and I assume in the regular mobile view, but haven't tested this yet), the hamburger menu for opening the advanced navigation panel has "open" when closed and "close" when open showing to the user.

When the interview language is set to something other than English, these two words aren't translated. They likely aren't part of the translation text file.

They need to be added to the text file AND all languages need "close" and "open" added to them in the appropriate languages.

image

Tested in © 2000-2023 IIT Chicago-Kent College of Law and CALI A2J 8.1.6-2-2023-03-14 on hydra 5/19/23

JessicaFrank commented 7 months ago

Here is the text file for translation with the additional phrases added at the end. I don't know what the element name actually is, so I just put the words that need to be added (are newish features/additions since 2019) at the end of the text file. A2J.Language.Template_withJFadditions.txt

tobiasnteireho commented 7 months ago

This is what is in production https://github.com/CCALI/a2jviewer/blob/c9497a1e22a4bc6b8c1aa9e1308c67b509ed95c6/src/mobile/util/tlang.js#L95

which should match

https://github.com/CCALI/a2jauthor/blob/9b4a30f8dfb00a1099adbbfa9a90d135650a9577/legacy/viewer/A2J_Languages.js#L163

JessicaFrank commented 7 months ago

Production is missing "Show Navigation", "Navigation Panel", and "Open" in all the languages supported. Those phrases were added to the viewer after the language file was created. The file I added above includes those, but I don't have the left side name for the elements that display those phrases in the English version.