search

CCBlueX / LiquidBounce

A free mixin-based injection hacked client for Minecraft using the Fabric API
https://liquidbounce.net/
GNU General Public License v3.0
1.48k stars 479 forks source link

[FEATURE] KillAura: Make KeepSprint unsprint for Criticals on hit #2533

Open Ancnymous opened 7 months ago

Ancnymous commented 7 months ago

LiquidBounce Branch

Nextgen

Describe your feature request.

Add a feature named 'UnSprint' on KillAura which when turned on will allow us to land critical hits on 1.9+ servers even when keepsprint is on and 'Criticals' module is off. When this option is on, KillAura will Remove the sprint for the duration of the hit in order to make a critical hit on 1.9+ servers because on servers that are 1.9+ you can't crit whilst sprinting. So To crit on versions that are 1.9+ you just have to stop sprinting like a tick before landing the hit and after landing the hit you can continue sprinting.

Additional context

This is useful because this would allow us to get critical hits on 1.9+ servers whilst having keepsprint on which makes us sprint even when hitting. Furthermore, this would also be boosting the capabilities of the newly added 'PrioritizeCriticals' settings on KillAura since currently it doesn't always crit when keepsprint is true because of the new game mechanic introduced on 1.9 version of Minecraft.

superblaubeere27 commented 7 months ago

Why did you close this?

Ancnymous commented 7 months ago

Why did you close this?

Re-posted this to bring it on top

superblaubeere27 commented 7 months ago

I already read it when you initially posted it last week. I did not have much too say about it. Currently KeepSprint gives the player unexpected signals about crits taking place when they don't. I have no quick solution for this problem.

We read all issues but we cannot work on all of them at the same time. Changing the name multiple times, closing the issue after only a week to push it into our notifications will not help. You may kindly ask for an update on the state of the issue, no problem, but this is a bit childish tbh.

Ancnymous commented 7 months ago

Also please put the 'Unsprint' settings inside the keepsprint module or integrate it into a completely new option inside KillAura as the feature should not be directly implemented in the keepsprint option as it is completely useless for 1.8.

Ancnymous commented 7 months ago

Did you read my suggestion about the superknockback module? If yes, did it seem useful enough? Personally I think it should be useful for a wide variety of people as they make the superknockback module more powerful.

Ancnymous commented 7 months ago

If you didnt read it heres the link: https://github.com/CCBlueX/LiquidBounce/issues/2601

superblaubeere27 commented 7 months ago

Please ask me for updates in the affected issue thread not in another.

Ancnymous commented 7 months ago

Please ask me for updates in the affected issue thread not in another.

Thanks for addressing this, I will try to follow your advice from the next time. However, The reason for me to post the link of the thread I want to be addressed here is because I have feared that the thread could've gotten unnoticed and since you have already noticed this thread.