CCBlueX / LiquidBounce

A free mixin-based injection hacked client for Minecraft using the Fabric API
https://liquidbounce.net/
GNU General Public License v3.0
1.41k stars 459 forks source link

[BUG] Button position confilct with ViaForge #896

Closed HowardZHY closed 1 year ago

HowardZHY commented 1 year ago

LiquidBounce Build/Version

b74

Operating System

Windows 11

Minecraft Version

1.8.9

Describe the bug

the antiforge button was replaced by viaforge button image

Steps to reproduce

install latest viaforge from curse and see

Client Log

/

Screenshots

image

1zun4secondary commented 1 year ago

Yes, I know about this, but what are you expecting from us?

HowardZHY commented 1 year ago

move button to somewhere else

1zun4secondary commented 1 year ago

Legacy is not going to receive any changes from me, so unlikely that this is going to change anytime soon.

HowardZHY commented 1 year ago

hope someone else can see this and fix

1zun4secondary commented 1 year ago

So I decided to add ViaForge as supported mod to the LiquidLauncher, because both projects share the same license and are open-source.

image

But before I modified the JAR and moved the button from x 5 to 211 and y 6 to 8. image I could also have modifed the code from https://github.com/FlorianMichael/ViaForge but that was much quicker.

Sadly there is no offical maven for ViaForge and of course the JAR is modified now anyway, so I uploaded it to our own server: https://maven.ccbluex.net/net/ccbluex/viaforge/1.8.9-2.0.0-patch1/viaforge-1.8.9-2.0.0-patch1.jar

Now it looks like this: image

FlorianMichael commented 1 year ago

I will probably remove the button in ViaForge 3 anyway and add a collapsible list on the right side of the page, then the problem should be solved.

CzechHek commented 1 year ago

Why not just move the AntiForge button elsewhere when ViaForge is installed? Certainly better than to make a fork of it and even distribute it.

FlorianMichael commented 1 year ago

yeah you could also go for something like that

1zun4secondary commented 1 year ago

Users on the LiquidLauncher have the properly fixed button position, anything else doesn't matter to me. The button has been there forever, on every LiquidBounce version that ever existed, just because one mod conflicts with this I am not going to change this.

FlorianMichael commented 1 year ago

I can move the button if LiquidBounce is installed