search

CCExtractor / beacon

Flutter application to share location with a group. (under development)
66 stars 147 forks source link

Make placeholder text in "Your Beacons" interactable #132

Closed devmrfitz closed 2 years ago

devmrfitz commented 2 years ago

Is your feature request related to a problem? Please describe. When the app launches and Your Beacons section is empty, the following screen is shown: image The circled buttons are yellow in colour and hence look interactable, but they aren't.

Describe the solution you'd like Try to connect these words to their respective actions, similar to the actual buttons

Are you working on this? Yes

ItsAdityaKSingh commented 2 years ago

Hey @devmrfitz! They are there for the sake of making the UI a bit informative and uniform. Those options are just above the tab bar and imo it would be unnecessary to give the text any actions. Your views upon this?

devmrfitz commented 2 years ago

Thanks for you opinions @ItsAdityaKSingh. Sounds fair that the extra actions might get repetitive. But the text being yellow also prompts the user that it is interactable in some manner. To avoid confusion, should we make the yellow "create" and "join" text back to black?

ItsAdityaKSingh commented 2 years ago

I guess leaving them as they are would be better cause they were introduced in the first place for the same purpose of bettering UI. Regarding it or any further queries could be answered by @nb9960 :)

nb9960 commented 2 years ago

Instead of making it actionable, turning it into bold black would be a better option to avoid confusion. Also why this panel is overlapping in your screen, have you pulled the recent commits?

devmrfitz commented 2 years ago

@nb9960 I do have the latest commits. Maybe it's due to it being an emulator and not a physical device?

ItsAdityaKSingh commented 2 years ago

@nb9960 I do have the latest commits. Maybe it's due to it being an emulator and not a physical device?

Maybe cause the sliding panel of your notifications panel is not quite what it should be like. It's a bit broader.