CCExtractor / beacon

Flutter application to share location with a group. (under development)
58 stars 148 forks source link

Disable Expired beacons to be accessed by users. #141

Closed Omegaviv closed 2 years ago

Omegaviv commented 2 years ago

There is no reason to let any user open any expired beacons, right?

Instead what we can do is add a popup whenever a user clicks on an expired beacon saying that the beacon has already expired join a new one or create a one.

https://user-images.githubusercontent.com/86337946/155526046-aef043fa-3d0e-4e78-955f-41c3fd573d6d.mp4

Do you think it is a good improvement?

ItsAdityaKSingh commented 2 years ago

I guess being able to open expired beacons and see the past hikes, followers, locations, etc., is as desired. It already shows that the hike is expired when it is opened up, but along with it also shows the extra info, so that's better imo :)

ItsAdityaKSingh commented 2 years ago

Could you also share details of what emulator/device you are running the app on? The button-text seem to be misaligned.

Omegaviv commented 2 years ago

Yes I am running on Vivo v11 pro

nb9960 commented 2 years ago

If a user navigates to the expired beacon's screen then it already displays that the hike has ended. Also as stated by @ItsAdityaKSingh if someone wants to know the route that the group followed or the users who were part of the group, then that screen might be useful. Closing this issue for now, if you want to add anything to do this then feel free to propose, I'll reopen the issue.