search

CCExtractor / beacon

Flutter application to share location with a group. (under development)
58 stars 148 forks source link

This line is misleading as a text field #158

Closed vik4114 closed 1 year ago

vik4114 commented 2 years ago

Is your feature request related to a problem? Please describe. This line is misleading as a text field and if it is acting as a partition still it is not symmetric

Screenshot Screenshot_1647773488_1

Describe the solution you'd like I think we should remove it

Describe alternatives you've considered -Else we can make it symmetric -Or Bring it just below the text field

Additional context Sol 1
Screenshot_1647773488_2

Sol2 Screenshot_1647773488_3

Are you working on this? (Yes/No) Yes

vik4114 commented 2 years ago

@nb9960 What do you think?

ItsAdityaKSingh commented 2 years ago

@vik4114 afaik that line is a mere partition between the two fields and is only for UI purposes. It has nothing to do with the textfields or symmetry. It's there to only get a general idea to users for where the divide lies between them.

vik4114 commented 2 years ago

@ItsAdityaKSingh But without the line it looks good

nb9960 commented 2 years ago

I guess the same follows for the other text fields too and because UI needs to be consistent, you'll have to make the changes throughout. Additionally, that line acted as a partition removing it doesn't look good, the latter one is still better (i.e, to add the line below the text field)

srockstech commented 2 years ago

@vik4114 Are you still working on this issue?

vik4114 commented 2 years ago

@srockstech Yes, I was stuck with other work, I will raise pr soon.

K1RA-16 commented 2 years ago

@srockstech Yes, I was stuck with other work, I will raise pr soon.

Hi vik can i work on this if possible ??

ItsAdityaKSingh commented 2 years ago

Hey, @vik4114, are you working on resolving this?

RohanSengupta326 commented 1 year ago

I think no one solved this issue, so I created a PR(#170). So please check. @ItsAdityaKSingh

pnkr01 commented 1 year ago

is this issue resolved ?? @ItsAdityaKSingh