CCExtractor / beacon

Flutter application to share location with a group. (under development)
64 stars 148 forks source link

Google & Facebook oauth sign up and sign in #160

Open jaiakash opened 2 years ago

jaiakash commented 2 years ago

Is your feature request related to a problem? Please describe. Currently, the app only accepts email sign in/signup. Having oauth would be better for the user, then user can sign in with ease. Also there is PR for email verification, having oauth wont even need email verification. (Although that feature would be required for user sign in with their email).

Describe the solution you'd like Having a google and/or Facebook oauth at sign-in page of app.

Are you working on this? (Yes/No) Not right now, but if I get confirmation from maintainer, I would start working on it.

codewithkushagra commented 2 years ago

I would like to work on this, I have implemented oauth in flutter previously, I can do it Can you assign it to me

nb9960 commented 2 years ago

@jaiakash @codewithkushagra Yes, this was planned but how will you guys implement it without updating the backend?

codewithkushagra commented 2 years ago

Actually, we don't have to make too many changes to backend, as by using google_sigin package we can maintain the login states, access tokens and refresh token in frontend itself and I will try to make the required changes in backend.

jaiakash commented 2 years ago

Yeah i agree, there are packages for facebook and google oauth which we can use without much changes in backend. Blog link - link Facebook package Google package

ItsAdityaKSingh commented 2 years ago

Are you working on proposing changes for this issue @jaiakash?

codewithkushagra commented 2 years ago

Hey, @ItsAdityaKSingh if @jaiakash is not working on this can I work on it? I have previously implemented such features so I can implement it easily, let me know if issue open to work on

jaiakash commented 2 years ago

Are you working on proposing changes for this issue @jaiakash?

No, I am not actively working on it. I guess @codewithkushagra can it if he has worked on a similar issue previously.

ItsAdityaKSingh commented 2 years ago

Ok! If @codewithkushagra you are willing to resolve this issue, I would like to discuss it first. Like how are you planning to change the backend to implement this feature? Currently, whoever registers, the information regarding the users, list of beacons, and everything is saved in our customized backend, where we easily retrieve the information about them. Using Google or Facebook would need to change how we currently keep records. What do you suggest?

asmitranjansinha commented 1 year ago

we can use firebase and google/facebook auth packages

asmitranjansinha commented 1 year ago

if anyone is not working on this issue, I can work on it @ItsAdityaKSingh

lalitkumawat1m commented 1 year ago

Hi, could you please assign this issue to me? I would love to work on it and contribute to the project.