CCExtractor / beacon

Flutter application to share location with a group. (under development)
58 stars 148 forks source link

TextFormField separator removal #170

Open RohanSengupta326 opened 1 year ago

RohanSengupta326 commented 1 year ago

Fixes #158

Describe the changes you have made in this PR -

Screenshots of the changes (If any) -

Screenshot 2022-10-13 at 4 13 20 PM Screenshot 2022-10-13 at 4 13 28 PM

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

ItsAdityaKSingh commented 1 year ago

Hey @RohanSengupta326! I guess it could be better to reduce and align the underline properly.

RohanSengupta326 commented 1 year ago

how about this? @ItsAdityaKSingh

Screenshot 2022-10-15 at 1 07 07 PM

Screenshot 2022-10-15 at 1 07 07 PM

ItsAdityaKSingh commented 1 year ago

Better! Try to move that eye icon away from the underline. It should not look to be in the text field.

RohanSengupta326 commented 1 year ago

@ItsAdityaKSingh

Screenshot 2022-10-16 at 2 08 00 PM

Screenshot 2022-10-16 at 2 08 51 PM

ItsAdityaKSingh commented 1 year ago

That's great! Could you also just push the eye icon up a little so that it comes above the underline horizontal space?

RohanSengupta326 commented 1 year ago

Is this height of the eye icon okay or is more needed? @ItsAdityaKSingh

Screenshot 2022-10-16 at 2 43 11 PM Screenshot 2022-10-16 at 2 43 21 PM

ItsAdityaKSingh commented 1 year ago

LGTM! @nb9960, could you review?

RohanSengupta326 commented 1 year ago

so should send the PR now or wait? @ItsAdityaKSingh

RohanSengupta326 commented 1 year ago

@nb9960

debug.keystore and pubspec.lock were changed automatically. I reverted the changes and committed including the UI changes. and also removed the separator widget as you asked. please check.

ItsAdityaKSingh commented 1 year ago

Hey @RohanSengupta326, could you please see PR #175 and discuss the need for separate cards for the fields or have the fields on the same card? You could look at the UI and suggest your ideas there too.