[BUG] Garbled SRT from over air transport stream (TS) encoded from HDHomerun Extend

CCExtractor / ccextractor

CCExtractor - Official version maintained by the core team

https://www.ccextractor.org

GNU General Public License v2.0

683 stars 420 forks source link

[BUG] Garbled SRT from over air transport stream (TS) encoded from HDHomerun Extend #1109

Open jamesbigler opened 4 years ago

jamesbigler commented 4 years ago

Please prefix your issue with one of the following: [BUG], [PROPOSAL], [QUESTION].

CCExtractor version (using the --version parameter preferably) : 0.88 (compiled on OSX with brew)

In raising this issue, I confirm the following (please check boxes, eg [X] - and delete unchecked ones):

[X] I have read and understood the contributors guide.
[X] I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present.
[X] I have checked that the issue I'm posting isn't already reported.
[X] I have checked that the issue I'm porting isn't already solved and no duplicates exist in closed issues and in opened issues
[X] I have used the latest available version of CCExtractor to verify this issue exists.

My familiarity with the project is as follows (check one, eg [X] - and delete unchecked ones):

[X] I have used CCExtractor just a couple of times.

Necessary information

Is this a regression (did it work before)? [X] NO | [ ] YES - please specify the last known working version
What platform did you use? [ ] Windows - [ ] Linux - [X] Mac
What were the used arguments? -delay 1500 test.ts -o test.v0.88.srt

Video links (replace text below with your links) This is a truncated file created with dd. Transport streams should support truncation. https://www.dropbox.com/s/6mivq9mdtupfiy4/test.ts?dl=0

Additional information Here's an example:

20
00:00:34,867 --> 00:00:41,472
        [Scrmieang]

This should say:

        [Screaming]

36
00:01:30,489 --> 00:01:32,856
Oh                              
, u yocan go right in.

This should say:

Oh, 
you can go right in.

Here's the output: https://www.dropbox.com/s/0oduki0uyhcmghq/test.srt?dl=0

$ ccextractor -delay 1500 test.ts -o test.srt
CCExtractor 0.88, Carlos Fernandez Sanz, Volker Quetschke.
Teletext portions taken from Petr Kutalek's telxcc
--------------------------------------------------------------------------
Input: test.ts
[Extract: 1] [Stream mode: Autodetect]
[Program : Auto ] [Hauppage mode: No] [Use MythTV code: Auto]
[Timing mode: Auto] [Debug: No] [Buffer input: No]
[Use pic_order_cnt_lsb for H.264: No] [Print CC decoder traces: No]
[Target format: .srt] [Encoding: UTF-8] [Delay: 1500] [Trim lines: No]
[Add font color data: Yes] [Add font typesetting: Yes]
[Convert case: No] [Video-edit join: No]
[Extraction start time: not set (from start)]
[Extraction end time: not set (to end)]
[Live stream: No] [Clock frequency: 90000]
[Teletext page: Autodetect]
[Start credits text: None]
[Quantisation-mode: CCExtractor's internal function]

-----------------------------------------------------------------
Opening file: test.ts
File seems to be a transport stream, enabling TS mode
Analyzing data in general mode

Found large gap(168) in PTS! Trying to recover ...
  0%  |  00:00
Found large gap(164) in PTS! Trying to recover ...

Found large gap(166) in PTS! Trying to recover ...

Found large gap(174) in PTS! Trying to recover ...
 99%  |  01:50Premature end of file - Transport Stream packet is incomplete (expected 188 bytes, got 36).
100%  |  01:51
Number of NAL_type_7: 55
Number of VCL_HRD: 0
Number of NAL HRD: 55
Number of jump-in-frames: 54
Number of num_unexpected_sei_length: 0

Total frames time:    00:01:51:611  (3345 frames at 29.97fps)

Min PTS:                00:00:02:729
Max PTS:                00:01:54:407
Length:              00:01:51:678
Done, processing time = 3 seconds
Issues? Open a ticket here
https://github.com/CCExtractor/ccextractor/issues

I viewed it in EyeTV, and it displayed the CC correctly, so I know the data is there.

thealphadollar commented 4 years ago

This issue is definitely reproducible though I have not been able to figure out what could be actually causing the issue at first place. @cfsmp3 Any leads?

cfsmp3 commented 4 years ago

Do the files play correctly in VLC? The subtitles I mean.

If yes, we have a bug. Otherwise I'd say it's a problem with the input.

On Fri, Sep 27, 2019, 19:34 Shivam Kumar Jha notifications@github.com wrote:

This issue is definitely reproducible though I have not been able to figure out what could be actually causing the issue at first place. @cfsmp3 https://github.com/cfsmp3 Any leads?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=ABNMTWNTETOLOYRWCOMMDE3QL27DVA5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72O3UI#issuecomment-536145361, or mute the thread https://github.com/notifications/unsubscribe-auth/ABNMTWO344VTWX3IOLRBJQLQL27DVANCNFSM4IX65YMQ .

jamesbigler commented 4 years ago

They seem to play fine for me with Windows VLC 3.0.8.

They also played fine with EyeTV as mentioned in the original report.

thealphadollar commented 4 years ago

The test.ts file you've provided isn't working in either of my video players. Can you please provide another file?

On Sat, Sep 28, 2019 at 9:03 AM jamesbigler notifications@github.com wrote:

They seem to play fine for me with Windows VLC 3.0.8.

They also played fine with EyeTV as mentioned in the original report.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=AH2K2IFZI77VRN6H2LIC7R3QL3GBBA5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72P2KI#issuecomment-536149289, or mute the thread https://github.com/notifications/unsubscribe-auth/AH2K2IBU5INQKSB4KC2VP3DQL3GBBANCNFSM4IX65YMQ .

jamesbigler commented 4 years ago

What video player are you using?

I’m not sure I can provide a different kind of file since the source is over the air transport streams.

What versions of VLC have you tried if you tried VLC?

On Sat, Sep 28, 2019 at 6:58 AM Shivam Kumar Jha notifications@github.com wrote:

The test.ts file you've provided isn't working in either of my video players. Can you please provide another file?

On Sat, Sep 28, 2019 at 9:03 AM jamesbigler notifications@github.com wrote:

They seem to play fine for me with Windows VLC 3.0.8.

They also played fine with EyeTV as mentioned in the original report.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=AH2K2IFZI77VRN6H2LIC7R3QL3GBBA5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72P2KI#issuecomment-536149289 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AH2K2IBU5INQKSB4KC2VP3DQL3GBBANCNFSM4IX65YMQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=ABRR2746L5IPRP7WGEHEYDTQL5IF3A5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72ZHPQ#issuecomment-536187838, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRR27YS2U2ZFJUQRTMF4K3QL5IF3ANCNFSM4IX65YMQ .

thealphadollar commented 4 years ago

VLC media player 3.0.8 Vetinari (revision 3.0.8-0-gf350b6b5a7)
VLC version 3.0.8 Vetinari (3.0.8-0-gf350b6b5a7)
Compiled by buildd on x86-ubc-01.debian.org (Sep  5 2019 18:01:50)
Compiler: gcc version 9.2.1 20190827 (Debian 9.2.1-6)
This program comes with NO WARRANTY, to the extent permitted by law.
You may redistribute it under the terms of the GNU General Public License;
see the file named COPYING for details.
Written by the VideoLAN team; see the AUTHORS file.

On Sat, Sep 28, 2019 at 7:15 PM jamesbigler notifications@github.com wrote:

What video player are you using?

I’m not sure I can provide a different kind of file since the source is over the air transport streams.

What versions of VLC have you tried if you tried VLC?

On Sat, Sep 28, 2019 at 6:58 AM Shivam Kumar Jha <notifications@github.com

wrote:

The test.ts file you've provided isn't working in either of my video players. Can you please provide another file?

On Sat, Sep 28, 2019 at 9:03 AM jamesbigler notifications@github.com wrote:

They seem to play fine for me with Windows VLC 3.0.8.

They also played fine with EyeTV as mentioned in the original report.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <

https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=AH2K2IFZI77VRN6H2LIC7R3QL3GBBA5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72P2KI#issuecomment-536149289

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/AH2K2IBU5INQKSB4KC2VP3DQL3GBBANCNFSM4IX65YMQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=ABRR2746L5IPRP7WGEHEYDTQL5IF3A5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72ZHPQ#issuecomment-536187838 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ABRR27YS2U2ZFJUQRTMF4K3QL5IF3ANCNFSM4IX65YMQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=AH2K2IDHINLQLZBE6RVWM6TQL5NW7A5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD722CMI#issuecomment-536191281, or mute the thread https://github.com/notifications/unsubscribe-auth/AH2K2IGZFQNGHMMNGR53XXTQL5NW7ANCNFSM4IX65YMQ .

jamesbigler commented 4 years ago

That’s the same version (at least by number) I used on Windows. I’m not sure what the differences are between the same version in different systems.

What error do you see?

On Sat, Sep 28, 2019 at 7:49 AM Shivam Kumar Jha notifications@github.com wrote:

VLC media player 3.0.8 Vetinari (revision 3.0.8-0-gf350b6b5a7)
VLC version 3.0.8 Vetinari (3.0.8-0-gf350b6b5a7)
Compiled by buildd on x86-ubc-01.debian.org (Sep 5 2019 18:01:50)
Compiler: gcc version 9.2.1 20190827 (Debian 9.2.1-6)
This program comes with NO WARRANTY, to the extent permitted by law.
You may redistribute it under the terms of the GNU General Public License;
see the file named COPYING for details.
Written by the VideoLAN team; see the AUTHORS file.
On Sat, Sep 28, 2019 at 7:15 PM jamesbigler notifications@github.com wrote:

What video player are you using?

I’m not sure I can provide a different kind of file since the source is over the air transport streams.

What versions of VLC have you tried if you tried VLC?

On Sat, Sep 28, 2019 at 6:58 AM Shivam Kumar Jha < notifications@github.com

wrote:

The test.ts file you've provided isn't working in either of my video players. Can you please provide another file?

On Sat, Sep 28, 2019 at 9:03 AM jamesbigler notifications@github.com wrote:

They seem to play fine for me with Windows VLC 3.0.8.

They also played fine with EyeTV as mentioned in the original report.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <

https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=AH2K2IFZI77VRN6H2LIC7R3QL3GBBA5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72P2KI#issuecomment-536149289

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/AH2K2IBU5INQKSB4KC2VP3DQL3GBBANCNFSM4IX65YMQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=ABRR2746L5IPRP7WGEHEYDTQL5IF3A5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72ZHPQ#issuecomment-536187838

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/ABRR27YS2U2ZFJUQRTMF4K3QL5IF3ANCNFSM4IX65YMQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=AH2K2IDHINLQLZBE6RVWM6TQL5NW7A5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD722CMI#issuecomment-536191281 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AH2K2IGZFQNGHMMNGR53XXTQL5NW7ANCNFSM4IX65YMQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=ABRR27YXRDXNBD3JFPZ5HPDQL5OFHA5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD722EUI#issuecomment-536191569, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRR27ZF7IAN7SKUKBICROTQL5OFHANCNFSM4IX65YMQ .

thealphadollar commented 4 years ago

It's just not playing.

On Sun, Sep 29, 2019 at 10:00 AM jamesbigler notifications@github.com wrote:

That’s the same version (at least by number) I used on Windows. I’m not sure what the differences are between the same version in different systems.

What error do you see?

On Sat, Sep 28, 2019 at 7:49 AM Shivam Kumar Jha <notifications@github.com
wrote:
VLC media player 3.0.8 Vetinari (revision 3.0.8-0-gf350b6b5a7)
VLC version 3.0.8 Vetinari (3.0.8-0-gf350b6b5a7)
Compiled by buildd on x86-ubc-01.debian.org (Sep 5 2019 18:01:50)
Compiler: gcc version 9.2.1 20190827 (Debian 9.2.1-6)
This program comes with NO WARRANTY, to the extent permitted by law.
You may redistribute it under the terms of the GNU General Public
License;
see the file named COPYING for details.
Written by the VideoLAN team; see the AUTHORS file.
On Sat, Sep 28, 2019 at 7:15 PM jamesbigler notifications@github.com wrote:

What video player are you using?

I’m not sure I can provide a different kind of file since the source is over the air transport streams.

What versions of VLC have you tried if you tried VLC?

On Sat, Sep 28, 2019 at 6:58 AM Shivam Kumar Jha < notifications@github.com

wrote:

The test.ts file you've provided isn't working in either of my video players. Can you please provide another file?

On Sat, Sep 28, 2019 at 9:03 AM jamesbigler < notifications@github.com> wrote:

They seem to play fine for me with Windows VLC 3.0.8.

They also played fine with EyeTV as mentioned in the original report.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <

https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=AH2K2IFZI77VRN6H2LIC7R3QL3GBBA5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72P2KI#issuecomment-536149289

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/AH2K2IBU5INQKSB4KC2VP3DQL3GBBANCNFSM4IX65YMQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=ABRR2746L5IPRP7WGEHEYDTQL5IF3A5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72ZHPQ#issuecomment-536187838

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/ABRR27YS2U2ZFJUQRTMF4K3QL5IF3ANCNFSM4IX65YMQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <

https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=AH2K2IDHINLQLZBE6RVWM6TQL5NW7A5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD722CMI#issuecomment-536191281

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/AH2K2IGZFQNGHMMNGR53XXTQL5NW7ANCNFSM4IX65YMQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=ABRR27YXRDXNBD3JFPZ5HPDQL5OFHA5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD722EUI#issuecomment-536191569 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ABRR27ZF7IAN7SKUKBICROTQL5OFHANCNFSM4IX65YMQ

.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=AH2K2ICN6LAS53EJITRTJ7TQMAVPDA5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD73H5HI#issuecomment-536247965, or mute the thread https://github.com/notifications/unsubscribe-auth/AH2K2IFBI7ZAURWIWCGUANDQMAVPDANCNFSM4IX65YMQ .

cfsmp3 commented 4 years ago

It plays for me, but the captions in VLC also appear totally garbled.

jamesbigler commented 4 years ago

OK, I was able to reproduce the (no) playback issue on OSX. VLC said it was getting end of file. Not sure why, because it is a transport stream and doesn't need an EOF.

I was able to get it to play back by

opening up VLC first with no file.
File->Advanced Open File.
Click "Browse".
Select test.ts.
make sure to select "Treat as pipe rather than as file".

Because TS is a stream format, this should work. I was able to open the file on my system this way.

See if this works for you.

On Sun, Sep 29, 2019 at 7:46 AM Carlos Fernandez Sanz < notifications@github.com> wrote:

It plays for me, but the captions in VLC also appear totally garbled.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=ABRR272DBWXOOQAX2GOBY2DQMCWUFA5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD73VD5A#issuecomment-536302068, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRR272UCYD5OI4LJWZRXALQMCWUFANCNFSM4IX65YMQ .

cfsmp3 commented 4 years ago

It plays in VLC for me but the closed captions VLC displays are garbled.

On Sun, Sep 29, 2019 at 9:11 PM jamesbigler notifications@github.com wrote:

OK, I was able to reproduce the (no) playback issue on OSX. VLC said it was getting end of file. Not sure why, because it is a transport stream and doesn't need an EOF.

I was able to get it to play back by

opening up VLC first with no file.

File->Advanced Open File.

Click "Browse".

Select test.ts.

make sure to select "Treat as pipe rather than as file".

Because TS is a stream format, this should work. I was able to open the file on my system this way.

See if this works for you.

On Sun, Sep 29, 2019 at 7:46 AM Carlos Fernandez Sanz < notifications@github.com> wrote:

It plays for me, but the captions in VLC also appear totally garbled.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=ABRR272DBWXOOQAX2GOBY2DQMCWUFA5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD73VD5A#issuecomment-536302068, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRR272UCYD5OI4LJWZRXALQMCWUFANCNFSM4IX65YMQ .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jamesbigler commented 4 years ago

Oh, I missed your second email about being able to play the file.

I'm not sure why the same file using the same version of VLC would have different behavior. That's frustrating.

Which stream are you using? I'm using "Closed captions 1"

Do you absolutely need to see VLC play the CC back correctly? I can provide more screen shots if needed.

[image: vlcsnap-2019-09-29-23h13m01s365.png]

Captured from ccextractor:

14 00:00:21,787 --> 00:00:24,722 Orge, t toou yr neighborho odMcnaDold's now.

On Sun, Sep 29, 2019 at 10:53 PM Carlos Fernandez Sanz < notifications@github.com> wrote:

It plays in VLC for me but the closed captions VLC displays are garbled.

On Sun, Sep 29, 2019 at 9:11 PM jamesbigler notifications@github.com wrote:

OK, I was able to reproduce the (no) playback issue on OSX. VLC said it was getting end of file. Not sure why, because it is a transport stream and doesn't need an EOF.

I was able to get it to play back by

opening up VLC first with no file.

File->Advanced Open File.

Click "Browse".

Select test.ts.

make sure to select "Treat as pipe rather than as file".

Because TS is a stream format, this should work. I was able to open the file on my system this way.

See if this works for you.

On Sun, Sep 29, 2019 at 7:46 AM Carlos Fernandez Sanz < notifications@github.com> wrote:

It plays for me, but the captions in VLC also appear totally garbled.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=ABRR272DBWXOOQAX2GOBY2DQMCWUFA5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD73VD5A#issuecomment-536302068 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ABRR272UCYD5OI4LJWZRXALQMCWUFANCNFSM4IX65YMQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=ABRR2753RRCAIXEKAX5HVMDQMGA33A5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD74NDVA#issuecomment-536400340, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRR272XAXBH5OFIT4YUUUTQMGA33ANCNFSM4IX65YMQ .

cfsmp3 commented 4 years ago

Using "closed captions 1" in VLC I get lots of garbled text.

It's not that we need it to play well in VLC. But if CCExtractor shows it garbled, and VLC shows it garbled, most likely the problem is with the input data and not with the software.

This is VLC for me:

jamesbigler commented 4 years ago

Right. I totally get that you want to make sure the data isn't corrupt to begin with.

I have three different instances where the captions worked for me.

Windows VLC 3.0.8
Mac VLC 3.0.8
Mac EyeTV from Elgato (this is a pretty old piece of software, but I used it for years to record and play back TV before getting Plex+NAS).

I don't have a linux machine to test with at the moment, but I'll ask around at work and see if I can get some additional corroboration.

On Tue, Oct 1, 2019 at 9:42 AM Carlos Fernandez Sanz < notifications@github.com> wrote:

Using "closed captions 1" in VLC I get lots of garbled text.

It's not that we need it to play well in VLC. But if CCExtractor shows it garbled, and VLC shows it garbled, most likely the problem is with the input data and not with the software.

This is VLC for me:

[image: image] https://user-images.githubusercontent.com/5949913/65977800-69b77900-e427-11e9-8250-a088b3b45ca9.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CCExtractor/ccextractor/issues/1109?email_source=notifications&email_token=ABRR2755KTKMILTQM6NY76DQMNVXHA5CNFSM4IX65YM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEABXNGY#issuecomment-537097883, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRR27ZN74CHXNRFIIOPOQDQMNVXHANCNFSM4IX65YMQ .

jamesbigler commented 4 years ago

Buddy at work tried on Linux with version VLC v 3.0.7 Vetinari, and it showed the captions correctly.

Would there be an issue with localization or some other aspect of VLC that would treat the data differently between our systems?

cfsmp3 commented 4 years ago

Plays OK for me in 3.0.8. Garbled in 2.2.3.

My first idea (haven't verified it) is that HDHomeRun is storing the captions in display order instead of decoding order along the frames and it's actually us garbling them while sorting. But this is just a theory.

In any case I guess a reasonable approach is go over the change file in the VLC and find where they fixed it, then look at the actual source code.