CCExtractor / ccextractor

CCExtractor - Official version maintained by the core team
https://www.ccextractor.org
GNU General Public License v2.0
715 stars 425 forks source link

[BUG] DVB subtitles at wrong offset #1248

Open NilsIrl opened 4 years ago

NilsIrl commented 4 years ago

CCExtractor version: 8e729cc

In raising this issue, I confirm the following:

Necessary information

Video links

Additional information

Follow up to: https://github.com/CCExtractor/ccextractor/issues/1104#issuecomment-573349570

this is the current output:

1
00:00:01,007 --> 00:00:02,972
<font color="#74750b">Nenhum outro passageiro</font>
<font color="#74750b">no seu veículo?</font>

2
00:00:02,973 --> 00:00:06,646
<font color="#74750b">Sim, senhor. Um acompanhante</font>
<font color="#74750b">no banco de trás.</font>

3
00:00:06,647 --> 00:00:08,646
<font color="#74750b">Um acompanhante</font>
<font color="#74750b">no banco de trás?</font>

4
00:00:08,882 --> 00:00:10,652
<font color="#74750b">Onde ele está agora?</font>

5
00:00:10,653 --> 00:00:14,652
<font color="#74750b">Onde ele está?</font>
<font color="#74750b">Não sei onde ele está, senhor.</font>

The timestamps are more or less 6600ms too early, and therefore, are out of sync with the voice of the actors.

cfsmp3 commented 4 years ago

Can you try 0.85? For DVB timing that was our reference "everything seems great" version.

On Fri, Apr 3, 2020 at 9:52 AM Nils notifications@github.com wrote:

CCExtractor version: 8e729cc

In raising this issue, I confirm the following:

I have read and understood the contributors guide. I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present. I have checked that the issue I'm posting isn't already reported. I have checked that the issue I'm porting isn't already solved and no duplicates exist in closed issues and in opened issues I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion. I have used the latest available version of CCExtractor to verify this issue exists.

Necessary information

Is this a regression (i.e. did it work before)? NO What platform did you use? Linux What were the used arguments? No arguments, just the filename

Video links

https://bit.ly/2kczK9X

Additional information

Follow up to: #1104 (comment)

this is the current output:

1

00:00:01,007 --> 00:00:02,972

Nenhum outro passageiro

no seu veículo?

2

00:00:02,973 --> 00:00:06,646

Sim, senhor. Um acompanhante

no banco de trás.

3

00:00:06,647 --> 00:00:08,646

Um acompanhante

no banco de trás?

4

00:00:08,882 --> 00:00:10,652

Onde ele está agora?

5

00:00:10,653 --> 00:00:14,652

Onde ele está?

Não sei onde ele está, senhor.

The timestamps are more or less 6600ms too early, and therefore, are out of sync with the voice of the actors.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

NilsIrl commented 4 years ago

Can you try 0.85?

I double checked (as I had already bisected the whole history in #1104), and can confirm that v0.85 has the same beginning timing/offsets as master, for the 10 first subtitle screens. After that, 0.85 and master are at different offsets.

cfsmp3 commented 4 years ago

How different? milliseconds can be OK, but if they diverge to the point of losing lip sync then well, no...

On Fri, Apr 3, 2020 at 12:53 PM Nils notifications@github.com wrote:

Can you try 0.85?

I double checked (as I had already bisected the whole history in #1104 https://github.com/CCExtractor/ccextractor/issues/1104), and can confirm that v0.85 has the same beginning timing/offsets as master, for the 10 first subtitle screens. After that, 0.85 and master are at different offsets.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CCExtractor/ccextractor/issues/1248#issuecomment-608628911, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNMTWOVD6PBVTE5PRZBHWLRKY5EBANCNFSM4L4IOUFA .

NilsIrl commented 4 years ago

How different?

As mentioned, 6600ms (more or less). So yes, lip sync is lost.

SuvigyaJain1 commented 3 years ago

I'll be taking up this issue

SuvigyaJain1 commented 3 years ago

VLC seems to detect 5 subs for the file - 4 CC and a DVB but only 2 work and both seem to in portuguese? How do I check the sync between portuguese subs and english audio? Sorry if its a dumb question

EDIT: resolved the issue in extracting subs. I didn't know I had to download the portuguese ocr traineddata file manually

cfsmp3 commented 3 years ago

VLC seems to detect 5 subs for the file - 4 CC and a DVB but only 2 work and both seem to in portuguese? How do I check the sync between portuguese subs and english audio? Sorry if its a dumb question

Manually. You course you won't be able to tell if the translation is correct, but you should easily see if the subtitles appear when the audio starts. (i.e. just load the .ts with your video player and then attach the generated subtitles to it).