search

CCExtractor / ccextractor

CCExtractor - Official version maintained by the core team
https://www.ccextractor.org
GNU General Public License v2.0
720 stars 426 forks source link

Create Linux AppImage #1348

Open cfsmp3 opened 3 years ago

cfsmp3 commented 3 years ago

The old build static script is useless. Let's replace it with AppImage as suggested ina comment below

canihavesomecoffee commented 3 years ago

It clones from master, so it will build the most recent... However the deps might not be up to date at all.

cfsmp3 commented 3 years ago

It clones from master, so it will build the most recent... However the deps might not be up to date at all.

Ah yes. We just like to leave irrelevant comments around

# wget https://sourceforge.net/projects/ccextractor/files/ccextractor/0.82/ccextractor.src.0.82.zip;
cfsmp3 commented 1 year ago

@prateekmedia could you check this out? Probably you can fix it without a lot of pain.

Better - just make -static an arg to build :-)

prateekmedia commented 1 year ago

Will look at it

prateekmedia commented 1 year ago

@cfsmp3 Could you explain what needs to be done in this? I looked at the file, ran it and it gave ccextractor-README.txt not found error.

cfsmp3 commented 1 year ago

@cfsmp3 Could you explain what needs to be done in this? I looked at the file, ran it and it gave ccextractor-README.txt not found error.

This will give you some context

https://github.com/CCExtractor/ccextractor/issues/597

Note that I renamed the script from @traceypooh to build-static.sh without actually changing the context (not a great idea, I realize).

Still, the script is obsolete now but the idea is good.

Are we able to produce a static binary using Docker as container? (docker is great for this because you can have a reliable environment no matter the starting point in the host).

If you think that's not possible, or really a lot of work, I guess we should just remove build-static.sh for now because obviously it's not working and it's just going to confuse people.

prateekmedia commented 1 year ago

I will try to do some testing from my side, let's see if I get it working.

prateekmedia commented 1 year ago

@cfsmp3 I think building static is not something we should do, instead why not build an AppImage (which is a universal format) and it will be able to run without being dependent on the system dependencies.

cfsmp3 commented 1 year ago

@cfsmp3 I think building static is not something we should do, instead why not build an AppImage (which is a universal format) and it will be able to run without being dependent on the system dependencies.

That's a really good idea. It would also solve the eternal issues with tesseract training files, etc

prateekmedia commented 1 year ago

@cfsmp3 Do you mean that tessdata should not be in the AppImage itself but installed separately?

cfsmp3 commented 1 year ago

@cfsmp3 Do you mean that tessdata should not be in the AppImage itself but installed separately?

No, the opposite! If we could have a AppImage that included tessdata it would be fantastic.

And if the image came from the CI so we could always have a known good nightly it would solve most of our issues with fixes taking forever to reach users because we release a new version once a year or so.

prateekmedia commented 1 year ago

yes

IshanGrover2004 commented 9 months ago

Hey, Can i try making AppImage in replace of build-static.sh file Or this issue is just for the CCExtracter team?

cfsmp3 commented 9 months ago

You can work on it

IshanGrover2004 commented 9 months ago

You can work on it

Okk then I'll research and will open PR after working on it

Any information I should know before working on it?

prateekmedia commented 9 months ago

@IshanGrover2004 You can began by reading appimage creation documentation and look at how other softwares are packaging the appimage.

IshanGrover2004 commented 9 months ago

Yes, already started reading official AppImage docs

IshanGrover2004 commented 9 months ago

Hi, I have studied about AppImage from its official docs and have gained a good understanding of how it is created and red the build-static.sh file. The build-static.sh file contains so many not working commands and links. I am planning to make a .sh file which will run a docker alpine and setup the static library binary through which ccextracter binary file will be made which will be further placed it into AppDir and make final .AppImage file and then cleanup everything. I want to confirm if my approach is correct.

IshanGrover2004 commented 9 months ago

I have opened PR #1592 . Can anyone from CCExtractor team look on it, so that i resolve current issues in there.