CCExtractor / ccextractor

CCExtractor - Official version maintained by the core team
https://www.ccextractor.org
GNU General Public License v2.0
686 stars 420 forks source link

[BUG] -stdout .ts crashes ccextractorwinfull.exe 094 #1478

Open drmargarit opened 1 year ago

drmargarit commented 1 year ago

CCExtractor version: 094

Necessary information

Additional information

drmargarit commented 1 year ago

The first two lines of the log are: 13:40:50: CCExtractor: E:\OneDrive\Develop\C#_PVRService\PVRService\bin\Debug\CCExtractor\ccextractorwinfull.exe, -s 10 -nots -nofc -trim -stdout "E:\Video\PVR\Movies\Walker Independence\Season1\WalkerIndependence_S1E4_4281.ts" 13:40:50: Launching process E:\OneDrive\Develop\C#_PVRService\PVRService\bin\Debug\CCExtractor\ccextractorwinfull.exe -s 10 -nots -nofc -trim -stdout "E:\Video\PVR\Movies\Walker Independence\Season1\WalkerIndependence_S1E4_4281.ts" The last two lines of the log are: thread '' panicked at 'index out of bounds: the len is 1 but the index is 1', src\decoder\service_decoder.rs:275:25 13:40:50: note: run with RUST_BACKTRACE=1 environment variable to display a backtrace 13:40:52: CCExtractor Process Exited with code -1073740791

cfsmp3 commented 1 year ago

@drmargarit is this still happening? (with the current binary, not 0.94)

drmargarit commented 1 year ago

Where would I find current binaries? 0.94 is the latest I can find.

cfsmp3 commented 1 year ago

Where would I find current binaries? 0.94 is the latest I can find.

You can get the last build from the integration system here: https://github.com/CCExtractor/ccextractor/suites/11510033399/artifacts/595056084

cfsmp3 commented 1 year ago

I tested in linux and it works well, but well, I guess that's doesn't mean it will work in Windows (but I'd be surprised if it didn't).

drmargarit commented 1 year ago

Sorry, it complains about vcruntime140_1D.DLL, vcruntime140D.dll and ucrtbased.dll being missing. Is there a link to the complete package including all of the support files?

cfsmp3 commented 1 year ago

Sorry, it complains about vcruntime140_1D.DLL, vcruntime140D.dll and ucrtbased.dll being missing. Is there a link to the complete package including all of the support files?

Probably you're missing some Microsoft libraries. You can download their redistributables here (that's linked from Microsoft website: https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170 )

https://aka.ms/vs/17/release/vc_redist.x64.exe

@canihavesomecoffee should be update our artifacts so this dependency is included? (I know we used to include some redist, maybe the version has changed?)

drmargarit commented 1 year ago

Installed the linked file. No help. Still complains about runtime files being missing.

cfsmp3 commented 1 year ago

Installed the linked file. No help. Still complains about runtime files being missing.

@canihavesomecoffee @prateekmedia can you assist with this one? I don't have any Windows system nearby

DhruvGandhi31 commented 1 year ago

I experienced a similar issue, however, after downloading the most recent redistributable packages, the problem was resolved for me. I suggest attempting to reinstall the software to see if it resolves the issue for you as well.

prateekmedia commented 1 year ago

@drmargarit Please download Visual C++ runtime package from here: https://github.com/abbodi1406/vcredist/releases/tag/v0.72.0 And Universal C Runtime(if needed) here: https://support.microsoft.com/en-us/topic/update-for-universal-c-runtime-in-windows-c0514201-7fe6-95a3-b0a5-287930f3560c

Let me know if it works for you

drmargarit commented 1 year ago

Installing the runtime package did help. It now runs without complaining about missing files, But the error persists. Here's a simpler method to reproduce it:

1) Download and install ccextractor 094. It installs to c:\program files (x86)\ccextractor by default 2) Download test video: https://1drv.ms/v/s!Ai_hpL0GElr6pPlwNV1W2zoAbi8BDA?e=8nvp6N 3) Put video into ccextractor directory 4) Open a command window and navigate to the ccextractor directory 5) Issue command: ccextractorwinfull.exe -stdout cctest1.ts 1>c:\users\public\ccStdOut.txt

The error will appear in the command window. A small snippet of successful closed caption text extraction will appear in c:\users\public\ccStdOut.txt. You may have to change the stdout redirect to a directory with proper permissions.

JLM