CCExtractor / ccextractor

CCExtractor - Official version maintained by the core team
https://www.ccextractor.org
GNU General Public License v2.0
721 stars 426 forks source link

[BUG] Rust decoder not used for 708 captions on MPEG-TS files #1500

Closed ArchitBhonsle closed 1 year ago

ArchitBhonsle commented 1 year ago

CCExtractor version: 0.94 (Build from master with cmake and no flags)

In raising this issue, I confirm the following:

Necessary information

Video links

https://sampleplatform.ccextractor.org/sample/7236304cfcfce141c7cec31647c1268a3886063390ce43c2f71188c70f5494c4

Additional Information

I'm pretty sure this is using the C decoder for 708. The reason I think this is C is because C does everything in uppercase while rust is in lowercase.

Command and logs Subtitles produced

marcybelardo commented 1 year ago

I think in this case, C was showing up because there isn't an implementation for the 608 decoder in Rust yet.

Reproducing logs with same command Command/logs with only 708 enabled

I believe even after the decoder for 708 is fixed, the C encoding will show up in stdout until 608 is ported to Rust too