[IMPROVEMENT] GPAC version updated to 2.2.0

DhruvGandhi31 commented 1 year ago

In raising this pull request, I confirm the following (please check boxes):

[x] I have read and understood the contributors guide.
[x] I have checked that another pull request for this purpose does not exist.
[x] I have considered, and confirmed that this submission will be valuable to others.
[x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
[x] I give this submission freely, and claim no ownership to its content.
[ ] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

[ ] I have never used CCExtractor.
[ ] I have used CCExtractor just a couple of times.
[x] I absolutely love CCExtractor, but have not contributed previously.
[ ] I am an active contributor to CCExtractor.

GPAC version is updated to 2.2.0 I have made changes only in gpacmp4 (ccextractor/src/thirdparty/gpacmp4/) library. Some changes are minor like 'GF_INSERT' is replaced by 'GF_ADD' and some changes are major like adding new method or replacing existing code snippet as a whole. Please note that these changes may reflect on other libraries and other part of code which uses gpac. The changes that I have made are in accordance with the official GPAC repository.

cfsmp3 commented 1 year ago

Please don't send pull requests that don't work - if it doesn't even compile it's not ready.

mohnishdeshpande commented 1 year ago

I am working on resolving the issues after migrating the gpac code from 1.0.1 to 2.2.0. I see there are a lot modifications required, I have already spent hours on it. I was wondering after I modify the code, if the build compiles and the ccextractor cli shows no quirks, should I consider the job as done?

cfsmp3 commented 1 year ago

I am working on resolving the issues after migrating the gpac code from 1.0.1 to 2.2.0. I see there are a lot modifications required, I have already spent hours on it. I was wondering after I modify the code, if the build compiles and the ccextractor cli shows no quirks, should I consider the job as done?

If it breaks things, no.

The job is to update GPAC 1 to 2, not to break what we have and leave us with garbage.

CCExtractor / ccextractor

[IMPROVEMENT] GPAC version updated to 2.2.0 #1515