search

CCExtractor / ccextractor

CCExtractor - Official version maintained by the core team
https://www.ccextractor.org
GNU General Public License v2.0
721 stars 426 forks source link

[IMPROVEMENT] Updated libGPAC to 2.2.0 #1526

Closed sachinrao8312 closed 1 year ago

sachinrao8312 commented 1 year ago

In raising this pull request, I confirm the following (please check boxes):

My familiarity with the project is as follows (check one):

libGPAC updated

New files added

configuration.h

Remotery.h

Some more files for error free compilation

I have updated the files which can compile on linux but I am unable to compile windows.

sachinrao8312 commented 1 year ago

Windows / build_ocr_hardsubx builds are failing due to vcpkg Error

sachinrao8312 commented 1 year ago

Here is log file for build_ocr_hardsubx_debug : Run cd vcpkg && vcpkg integrate install && vcpkg install leptonica tesseract ffmpeg --triplet x64-windows-static-md Applied user-wide integration for this vcpkg root. CMake projects should use: "-DCMAKE_TOOLCHAIN_FILE=D:/a/ccextractor/ccextractor/vcpkg/scripts/buildsystems/vcpkg.cmake"

All MSBuild C++ projects can now #include any installed libraries. Linking will be handled automatically. Installing new libraries will make them instantly available. Computing installation plan... The following packages will be built and installed:

CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:32 (message):

  Failed to download file with error: 1
  If you are using a proxy, please check your proxy setting. Possible causes are:

  1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable
     to `https://address:port`. This is not correct, because `https://` prefix
     claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr
     , etc..) is an HTTP proxy. Try setting `http://address:port` to both
     HTTP_PROXY and HTTPS_PROXY instead.

  2. If you are using Windows, vcpkg will automatically use your Windows IE Proxy Settings
     set by your proxy software. See https://github.com/microsoft/vcpkg-tool/pull/77
     The value set by your proxy might be wrong, or have same `https://` prefix issue.

  3. Your proxy's remote server is out of service.

  If you've tried directly download the link, and believe this is not a temporary
  download server failure, please submit an issue at https://github.com/Microsoft/vcpkg/issues
  to report this upstream download server failure.

Call Stack (most recent call first): scripts/cmake/vcpkg_download_distfile.cmake:270 (z_vcpkg_download_distfile_show_proxy_and_fail) scripts/cmake/vcpkg_acquire_msys.cmake:26 (vcpkg_download_distfile) scripts/cmake/vcpkg_acquire_msys.cmake:67 (z_vcpkg_acquire_msys_download_package) scripts/cmake/vcpkg_acquire_msys.cmake:345 (z_vcpkg_acquire_msys_declare_package) ports/ffmpeg/portfile.cmake:48 (vcpkg_acquire_msys) scripts/ports.cmake:147 (include)

error: building ffmpeg:x64-windows-static-md failed with: BUILD_FAILED error: Please ensure you're using the latest port files with git pull and vcpkg update. Then check for known issues at: https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+ffmpeg You can submit a new issue at: https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[ffmpeg]+Build+error Include '[ffmpeg] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above. vcpkg-tool version: 2023-03-14-105f7f7e8a5ea10dfac9874ff9d1a6bacba5f454 vcpkg-scripts version: a7b6122f6 2023-02-24 (5 weeks ago)

Please use the prefilled template from D:\a\ccextractor\ccextractor\vcpkg\installed\vcpkg\issue_body.md when reporting your issue. Error: Process completed with exit code 1.

canihavesomecoffee commented 1 year ago

Current master is building on Windows, so if this PR breaks something, it can't be merged until it builds again.

sachinrao8312 commented 1 year ago

Current master is building on Windows, so if this PR breaks something, it can't be merged until it builds again.

Okay, guide me what needed to be done to build them

ccextractor-bot commented 1 year ago

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 0/13
CEA-708 0/14
DVB 0/7
DVD 0/3
DVR-MS 0/2
General 0/27
Hauppage 0/3
MP4 0/3
NoCC 0/10
Options 0/87
Teletext 0/21
WTV 0/13
XDS 0/34

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

sachinrao8312 commented 1 year ago

All the builds are successful now

cfsmp3 commented 1 year ago

All the builds are successful now

There's a merge conflict, can you fix it?

sachinrao8312 commented 1 year ago

All the builds are successful now

There's a merge conflict, can you fix it?

I will look into it today

ccextractor-bot commented 1 year ago

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 0/13
CEA-708 0/14
DVB 0/7
DVD 0/3
DVR-MS 0/2
General 0/27
Hauppage 0/3
MP4 0/3
NoCC 0/10
Options 0/87
Teletext 0/21
WTV 0/13
XDS 0/34

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

ccextractor-bot commented 1 year ago

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 0/13
CEA-708 0/14
DVB 0/7
DVD 0/3
DVR-MS 0/2
General 0/27
Hauppage 0/3
MP4 0/3
NoCC 0/10
Options 0/87
Teletext 0/21
WTV 0/13
XDS 0/34

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

prateekmedia commented 1 year ago

@cfsmp3 I guess this can be merged now

cfsmp3 commented 1 year ago

@cfsmp3 I guess this can be merged now

@prateekmedia I'd be more comfortable if it passed tests (not just build, but actual sample processing). This is a big change :-)

Also, if we are going to be switching to package libGPAC vs vendored, not totally sure we want to get into this?

@canihavesomecoffee how's the CI coming along?