Closed IshanGrover2004 closed 9 months ago
This PR is ready to review @PunitLodha if any suggestion, then let me know
@IshanGrover2004 The SCC captions generated do not work well for the fixing the original issue #1423. Did you try fixing captions for the video provided there? https://github.com/CCExtractor/ccextractor/issues/1423#issuecomment-1073240342
The SCC captions generated do not work well for the fixing the original issue #1423. Did you try fixing captions for the video provided there? #1423 (comment)
Yeah, I tested that & that is because the captions are currently get overlapping in it & I did push the solution for overlapping but maybe problem occurs in generating captions I'll try to solve this by looking the correct SCC caption and my generated one & get back to you
Hey @PunitLodha I did test and do some research and here is what i got
Captions is perfectly made, its just because of formatting issues
And here is the diff of correct scc and scc generated by my code. Do have a look once. Do you know how can i decide using code when i need to place things like 94f2 94f2
to move cursor to row 15, column 4 ?
And here is the diff of correct scc and scc generated by my code.
Where did you get the correct SCC from? According to the original issue, this one seems to be correct, https://github.com/CCExtractor/ccextractor/issues/1426#issuecomment-1079731749
Where did you get the correct SCC from? According to the original issue, this one seems to be correct, #1426 (comment)
I don't remember the tool name but i have run it & its running correctly And the comment has incomplete captions
Anything else left @PunitLodha ?
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit deaa4a6...:
Report Name | Tests Passed |
Broken | 12/13 |
CEA-708 | 14/14 |
DVB | 4/7 |
DVD | 3/3 |
DVR-MS | 2/2 |
General | 16/27 |
Hauppage | 1/3 |
MP4 | 3/3 |
NoCC | 10/10 |
Options | 82/86 |
Teletext | 21/21 |
WTV | 13/13 |
XDS | 27/34 |
All tests passing on the master branch were passed completely.
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info.
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f449d06...:
Report Name | Tests Passed |
Broken | 13/13 |
CEA-708 | 14/14 |
DVB | 4/7 |
DVD | 3/3 |
DVR-MS | 2/2 |
General | 24/27 |
Hauppage | 3/3 |
MP4 | 3/3 |
NoCC | 10/10 |
Options | 84/86 |
Teletext | 21/21 |
WTV | 8/13 |
XDS | 34/34 |
All tests passing on the master branch were passed completely.
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
[ ] I am an active contributor to CCExtractor.
I have tested some of the videos and it is working. Closes #1426 (and in order to fix #1423)