Closed IshanGrover2004 closed 5 months ago
LGTM. I'm just wondering why the CI is failing 🤔
Yeah mac CI fails for the hardsubx part which is not even touched
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f08febf...:
Report Name | Tests Passed |
Broken | 12/13 |
CEA-708 | 14/14 |
DVB | 4/7 |
DVD | 3/3 |
DVR-MS | 2/2 |
General | 16/27 |
Hauppage | 1/3 |
MP4 | 2/3 |
NoCC | 10/10 |
Options | 82/86 |
Teletext | 21/21 |
WTV | 0/13 |
XDS | 27/34 |
All tests passing on the master branch were passed completely.
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Closes #1606
Issue addresed
This pull request addresses issue #1606 where the get_write_interval function incorrectly returns (0,209) for a packet does not contain captions, implying that caption packets are available from index 0 to 209 which needs to be corrected.
Correction Made
The correction ensures that the correct interval (0,0) is returned, indicating that there are no captions available to write.
Implementation Details
By initialising
last
variable which stores last caption available by 0