CCExtractor / ccextractor

CCExtractor - Official version maintained by the core team
https://www.ccextractor.org
GNU General Public License v2.0
707 stars 422 forks source link

[rust] add parser #1619

Closed prateekmedia closed 1 month ago

prateekmedia commented 3 months ago

In raising this pull request, I confirm the following (please check boxes):

My familiarity with the project is as follows (check one):


Rewrote argument parsing with all the structs and enums too into rust.

Help arguments demo: image

Closed old PR as sample platform broke for it: #1547

ccextractor-bot commented 2 months ago

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f12f12b...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 24/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 78/86
Teletext 21/21
WTV 1/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

ccextractor-bot commented 2 months ago

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit d6ccf1b...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 83/86
Teletext 21/21
WTV 13/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

PunitLodha commented 2 months ago

@prateekmedia also fix the merge conflicts

prateekmedia commented 1 month ago

@PunitLodha Done!

PunitLodha commented 1 month ago

@prateekmedia could you take a look at why the CI is failing

prateekmedia commented 1 month ago

@PunitLodha Done!

IshanGrover2004 commented 1 month ago

@prateekmedia @PunitLodha Are the sample test ran on this PR, Because I tested some samples on current CCExtractor code & its crashes which was working fine before this merging happens (I checked on each commit through when it is failing, found out this is the one which causes).

Sample platform on commit - Linux & Windows

prateekmedia commented 1 month ago

@IshanGrover2004 The teletext PR will resolve the crashes currently.