CCExtractor / ccextractor

CCExtractor - Official version maintained by the core team
https://www.ccextractor.org
GNU General Public License v2.0
722 stars 427 forks source link

[FEAT] Add log module in lib_ccxr #1622

Closed IshanGrover2004 closed 4 months ago

IshanGrover2004 commented 4 months ago

In raising this pull request, I confirm the following (please check boxes):

My familiarity with the project is as follows (check one):


Closes #1553

This PR adds functions and macros used for logging operations. The functions of this PR have not been integrated into the C codebase since there is no safe or easy way to pass variable number of arguments (as used in printf) from C to Rust. But the code for initializing the logger from C to Rust is included.

After this PR merge, anybody can use macros like info!, fata!, error!, debug! (Just like mprint, fatal, etc in C) for logging purposes after initializing logger using ccxr_init_basic_logger

IshanGrover2004 commented 4 months ago

@PunitLodha The PR is ready, you can review it

ccextractor-bot commented 4 months ago

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit d6ccf1b...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 24/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 85/86
Teletext 21/21
WTV 13/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

elbertronnie commented 4 months ago

Just got to know about this due to the closing of #1551. @IshanGrover2004 If you have any doubts regarding the code written by me, you can ask in Github or Slack. I can probably help as an external reviewer.

IshanGrover2004 commented 4 months ago

Sure @elbertronnie Thank you 😊 btw

IshanGrover2004 commented 4 months ago

@PunitLodha Did the changes

ccextractor-bot commented 4 months ago

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f12f12b...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 24/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 84/86
Teletext 21/21
WTV 2/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.