CCExtractor / ccextractor

CCExtractor - Official version maintained by the core team
https://www.ccextractor.org
GNU General Public License v2.0
728 stars 430 forks source link

[FEAT] Add time units module in `lib_ccxr` #1623

Closed IshanGrover2004 closed 4 months ago

IshanGrover2004 commented 4 months ago

In raising this pull request, I confirm the following (please check boxes):

My familiarity with the project is as follows (check one):


Closes #1556

This PR adds types that enables to store time in different representations like simple milliseconds, number of frames, etc. And also allow to interconvert between them. It also provides functions for formatting time in different kinds of formats. Certain functions are integrated into C codebase.

In comparision with PR #1556, I initiated lib_ccxr/utils/time.rs for only functions mentioned in utility.c & lib_ccxr/time/units.rs for necessary implementation(struct, enums, functions) of any work related to timings. This lib_ccxr/time will be continued later as well for more timings code coversion

ccextractor-bot commented 4 months ago

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f12f12b...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 24/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 84/86
Teletext 21/21
WTV 1/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

PunitLodha commented 4 months ago

@IshanGrover2004 more conflicts here

IshanGrover2004 commented 4 months ago

@IshanGrover2004 more conflicts here

Done @PunitLodha