CCExtractor / ccextractor

CCExtractor - Official version maintained by the core team
https://www.ccextractor.org
GNU General Public License v2.0
722 stars 427 forks source link

[IMPROVEMENT] Ignore version check on mxf essence container #1631

Closed aipsvrr closed 3 months ago

aipsvrr commented 3 months ago

In raising this pull request, I confirm the following (please check boxes):

My familiarity with the project is as follows (check one):


{pull request content here}

aipsvrr commented 3 months ago

Hi, There is an issue when subtitles are present in mxf asset but couldn't extracted because defined in code mxf_caption_essence_container (MXF_CT_ANC) has version '9' and one from asset I met has another version. By ignoring version byte (in case of mxf) srt extracts successfully. So an idea of current PR is to ignore version of mxf caption essence container as it is allowed by smpte standard ("6.3 KLV Coding"): Note: SMPTE ST 336 specifies that KLV parsers can ignore the version number or use the version number as an additional guide and consistency check in the process of parsing a KLV Key. Thanks!

cfsmp3 commented 3 months ago

LGTM but can you add it to the CHANGELOG as well? It's noteworthy.

aipsvrr commented 3 months ago

Hi @cfsmp3 , Sure! Changelog updated. Thanks!