Closed IshanGrover2004 closed 2 weeks ago
@prateekmedia Can you run cargo clippy -- -D warnings
in parser.rs
. See there are some warning like assert!(false)
.
So if you have any PR opened then fix in that or else let me know, I'll fix it in this PR
@PunitLodha You can review the PR Regression test result is looking good as well
For the Windows build CI failing, Here is the reason:
Edit: Fixed it
@IshanGrover2004 could you fix the conflict?
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 1a13bbb...:
Report Name | Tests Passed |
Broken | 13/13 |
CEA-708 | 14/14 |
DVB | 7/7 |
DVD | 3/3 |
DVR-MS | 2/2 |
General | 27/27 |
Hauppage | 3/3 |
MP4 | 3/3 |
NoCC | 10/10 |
Options | 85/86 |
Teletext | 21/21 |
WTV | 13/13 |
XDS | 34/34 |
All tests passing on the master branch were passed completely.
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info.
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 1a13bbb...:
Report Name | Tests Passed |
Broken | 12/13 |
CEA-708 | 9/14 |
DVB | 4/7 |
DVD | 3/3 |
DVR-MS | 2/2 |
General | 15/27 |
Hauppage | 2/3 |
MP4 | 3/3 |
NoCC | 10/10 |
Options | 83/86 |
Teletext | 21/21 |
WTV | 0/13 |
XDS | 22/34 |
All tests passing on the master branch were passed completely.
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info.
@PunitLodha I think you can merge this, this PR is fine ig
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Closes #1558
This PR adds types and functions to store and calculate timing related information during the decoding process. The functions are integrated into C. After this PR merge,
ccx_common_timing.c
&ccx_common_timing.h
file is completed ported to rust