CCExtractor / taskwarrior-flutter

This is the repo of mobile app of taskwarrior

https://play.google.com/store/apps/details?id=com.ccextractor.taskwarriorflutter

GNU General Public License v3.0

103 stars 86 forks source link

Dev #315

Closed Sabra-xD closed 4 months ago

Sabra-xD commented 4 months ago

Description

A notifier needed to be displayed for the user in a snackBar. Wrapped the AlertDialog of add_Task with a Scaffold, so the snackBar's ScaffoldMessanger can locate it and displayed the message. Also, highlighted the due time to be in red when the time selected is in the past.

AlertDialog is being displayed if the user haven't set up a TaskServer.

Fixes #(314 & 308 & 316)

Screenshots

Screenshot_2024-02-23-07-59-30-60_9bdaab249332ff0aa81548d24e981681

Screenshot_2024-02-25-01-56-21-82_9bdaab249332ff0aa81548d24e981681

overflow

Checklist

[ ] Tests have been added or updated to cover the changes
[ ] Documentation has been updated to reflect the changes
[x] Code follows the established coding style guidelines
[x] All tests are passing

Sabra-xD commented 4 months ago

Hey, @Pavel401 I remove the flushBar from earlier since it caused and issue with adding the task, it didn't close it if the flush bar was still on screen for its 2 seconds, and I just made do with the snackBar instead.

Pavel401 commented 4 months ago

Hi @Sabra-xD, thank you for submitting the PR. By the way, could you replace the dialog with a snack bar on the task server page? In most places, we use Snackbar throughout the app, so it would be great if the new one matched. Also, please make sure that the snack bar matches the theme of the app, both in dark and light mode. Thank you!

Sabra-xD commented 4 months ago

@Pavel401 Done.

Sabra-xD commented 4 months ago

Hey @Pavel401 I have added the solution for the most recent issue to the PR.

Pavel401 commented 4 months ago

From next time please send multiple PRs for each issue. @Sabra-xD