CCExtractor / taskwarrior-flutter

This is the repo of mobile app of taskwarrior
https://play.google.com/store/apps/details?id=com.ccextractor.taskwarriorflutter
GNU General Public License v3.0
103 stars 86 forks source link

Adding wait time causes the notification to be issued twice @ the same time. #319

Closed Sabra-xD closed 4 months ago

Sabra-xD commented 4 months ago

Describe your issue

Once a task is created, accessing the task and adding a wait time, which I assume is the time the user requests to be notified of the task again, causes the task notification to be sent twice once the task is due.

I assume that the wait time must come before the second notification is sent out.

Also, the back ground color is not compatible with the chosen theme light/dark mode. It's just set to light mode.

Steps to reproduce

None

What was the expected result?

None

Put here any screenshots or videos (optional)

2 notifications Screenshot_2024-02-27-07-25-14-37_9bdaab249332ff0aa81548d24e981681

How can we contact you (optional)

None

Would you like to work on this issue?

Yes

By submitting this issue, I have confirmed that:

Pavel401 commented 4 months ago
Screenshot 2024-02-28 at 8 15 49 PM

I have set the wait and due time on the same date, only the time is different. However, I have received only one notification according to the due date. For the wait time, I did not receive any notifications.

Sabra-xD commented 4 months ago

I sat the wait time to be after the due time and it gave me 2 notifications once the due time was on.

Video:

https://drive.google.com/file/d/1-O1gCb3nDbAtEz_JbdO7Hjltw34sZmDE/view?usp=sharing

Pavel401 commented 4 months ago

Hi there! I just wanted to share my thoughts on receiving notifications for tasks with due dates. In my opinion, it's perfectly fine to receive two notifications - one on the due date and another a bit earlier to remind us that the deadline is approaching.

I also found some information on the official documentation which states that we can use a "wait" date to hide tasks that are far into the future and we don't want to see them on our lists until it gets closer to the due date. For example, we can use the command "task 1 modify wait:30th" to hide a task until the 30th of the month. This way we won't be distracted by tasks that are not relevant yet.

It's important to note that a due date is not required to use the "wait" feature. I hope this helps clarify things!

Sabra-xD commented 4 months ago

Okay...That's a good idea. But from the video I sent...It clearly shows 2 notifications sent @ the same time. Then when the wait time is reached, another notification is sent. Totalling to 3 notifications.

I fail to see how 2 notifications is intentional when task is due.

Because if a task is set, with out wait time, you'll only receive a notification on its due time.

But in case of setting wait time, it sends 2 on due time and 1 on wait time.

So, I believe we need to remove 1 of the 2 notifications sent on the due time.

And add the feature you recommended where we notify the user of an upcoming task before its due time.