CCExtractor / taskwarrior-flutter

This is the repo of mobile app of taskwarrior

https://play.google.com/store/apps/details?id=com.ccextractor.taskwarriorflutter

GNU General Public License v3.0

103 stars 86 forks source link

feat: Feature in which Floating Buttons like "New Tasks" and "Move to Top" not overlapping with Tasks Tiles #339

Closed Gaurav-Kushwaha-1225 closed 2 months ago

Gaurav-Kushwaha-1225 commented 2 months ago

Description

According to latest android updates, the floating button is below the last tile in a scrollable system.

Behaviour of Floating Button in WhatsApp at Last Tile	Earlier Task Warrior App Behavior	Task Warrior App Behavior after adding the Feature

Fixes #346

I have raised the issue with issue no #346

Screenshots

Screenshots are there above. You can verify them.

Checklist

[ ] Tests have been added or updated to cover the changes
[x] Documentation has been updated to reflect the changes
[x] Code follows the established coding style guidelines
[ ] All tests are passing

BrawlerXull commented 2 months ago

Try not to push your pubspec.lock file @Gaurav-Kushwaha-1225

Gaurav-Kushwaha-1225 commented 2 months ago

Dear Maintainers,

I apologize for the confusion caused by the recent actions on my pull request. I mistakenly closed the PR and deleted the branch, but I have since restored it and reopened the PR.

I understand that this may have caused some disruption, and I sincerely apologize for any inconvenience. I appreciate your patience and understanding in this matter.

I kindly request you to consider merging the PR if everything is in order. Please let me know if there are any issues or further changes required.

Thank you for your time and consideration.

@BrawlerXull And I saw a previous merged PR #336 has pushed pubspec.lock files too. So, I did the same. But definitely I will be careful next time.

BrawlerXull commented 2 months ago

I'm not the maintainer here :) keep doing the work man hope to see more prs from you 👍

Pavel401 commented 2 months ago

Please make sure to create an issue before submitting a pull request (PR). @Gaurav-Kushwaha-1225

Gaurav-Kushwaha-1225 commented 2 months ago

@Pavel401, Just wanted to follow up on this pull request - I've addressed the requested changes. Please take a look and let me know if there's anything else needed.

Thanks!

BrawlerXull commented 2 months ago

Hey, sometimes reviews takes time. Also, please create an issue!

Pavel401 commented 2 months ago

@Gaurav-Kushwaha-1225 Did you push all your check-ins? Can't see the new changes.