Closed duckcommit closed 6 months ago
can i work on this issue?
I was planning to work on it @Adiii1436 & @nidhin29. But it's okay. First, wait for the maintainer to decide whether it is a good idea or not,. After that, one of you can work on it. Meanwhile both of you can set up your dev environment.
I understand what you mean, but we'll need a preview to be sure that it actually suits the theme and doesn't look too odd.
@MarkisDev, here is the preview.
Before the border.
It gives more like an effect to just the selected label.
After the border.
Here you can notice that the readability has increased compared to the old. Our primary color is also preserved.
Same applied in dark mode, just to match with the overall theme. Otherwise there will be a border for light but not for dark which is not a good design idea.
Description
If you check the bottom nav, when it is selected, the readability of the green font is less. So, how about we add a text border/stroke to the selected text? In this case, let's add a very thin black border. I am suggesting a thin border because the fluorescent green is the entire essence of the app. So, the expected output would be to have a green font with a slight black border/stroke.
Inorder to match this in dark mode, we can give a white thin border to the selected bottom nav option.
Screenshots