CCExtractor / ultimate_alarm_clock

GNU General Public License v2.0
70 stars 126 forks source link

Feature: Added Manual Time Entry Option in Timer #452

Closed superiorsd10 closed 8 months ago

superiorsd10 commented 8 months ago

Description

Currently, the app only offers the TimePickerSpinner for setting timer duration. This pull request introduces manual time entry functionality to enhance user experience and provide an alternative input method.

Proposed Changes

Fixes #293

Screenshots

https://github.com/CCExtractor/ultimate_alarm_clock/assets/92971894/be1386a6-4be2-493c-b40c-5a15d9cae66c

Checklist

keyurgit45 commented 8 months ago

Hello @superiorsd10,

I noticed that in the bottom_navigation_bar_bindings file, you have added Get.lazyPut(() => AddOrUpdateAlarmController());. However, this is causing an issue where the AddOrUpdateAlarmController is initializing on the homepage, which is resulting in the time not getting updated when opening any alarm page. or am I missing something?

Can you please take a moment to look into this? Attached below is a video showing the issue. Thank you.

https://github.com/CCExtractor/ultimate_alarm_clock/assets/75253653/a45a4e60-8155-4d12-ab14-9ed71252bd17

superiorsd10 commented 8 months ago

Sure, I'll be looking into it :)