search

CCExtractor / ultimate_alarm_clock

GNU General Public License v2.0
68 stars 122 forks source link

Bug: The Rings in is not initialized correctly. #531

Closed duckcommit closed 2 months ago

duckcommit commented 5 months ago

Description

If you check the screenshot, you can see that the time is 3:20, alarm is being set for 3:18 and it shows rings in less than one minute.

The problem is that, once you press the + button to add an alarm, you cancel it, and come back to home, and then again press the + button, the rings in is not getting updated until you touch the timepicker.

Its a good issue, If anyone is looking for issues, maybe you could have a try at it. If no one is interested then I will take it over.

Screenshots

Screenshot_20240326_152020

MarkisDev commented 5 months ago

I've assigned this to you for now. Let me know if you get stuck somewhere :)

fierychicken65 commented 5 months ago

Hey if the issue is still open may I work on it?

duckcommit commented 5 months ago

Yes, it is open @fierychicken65. Give it a try.

fierychicken65 commented 5 months ago

hey @duckcommit is the '+' button being used only to add more alarms right? Or is it being used to update and add alarms?

duckcommit commented 5 months ago

Yes @fierychicken65 , the + button is used to add the alarm. In order to update the alarm, you can simply click on an existing alarm.

fierychicken65 commented 5 months ago

hey @duckcommit just fixed an issue that wasn't allowing the user to add more alarms just after adding an alarm. Clicking on the + button used to update an alarm instead of creating a new alarm. Before:

https://github.com/CCExtractor/ultimate_alarm_clock/assets/116811583/4ff97a9f-7a2a-49dc-a6f7-b46b77ced6c4

After:

https://github.com/CCExtractor/ultimate_alarm_clock/assets/116811583/e2b62016-8628-4142-bdd2-5dda5297df83

duckcommit commented 5 months ago

Oh that's great @fierychicken65 . Did you raise a PR regarding this? What you need to do is that, you need to raise an issue first, stating the problem. Then raise a PR regarding this. After that the maintainer can review it and merge it.

If you need any help regarding this, please ping me anytime. I'm glad to help!!

fierychicken65 commented 5 months ago

Hi @duckcommit so I should raise a seperate issue for this right?

duckcommit commented 5 months ago

Yes @fierychicken65 . That's exactly what you should do.

shreygupta799 commented 2 months ago

Hey! may I give a try, if the issue is still open

AryanSarafDev commented 2 months ago

Hey! may I give a try, if the issue is still open

Hey! @shreygupta799 This issue is fixed. But if you want to try there's a bug which doesn't initialise the values when updating an alarm's time by clicking on it and creates a new duplicate alarm when updated. You can go through it and start a new issue if you want to fix it. Ask me if you have any doubts!