CCExtractor / ultimate_alarm_clock

GNU General Public License v2.0
68 stars 122 forks source link

Bug: The alarm sound continues to play in the background even when attempting to select a new sound or exiting the dialog. #536

Closed davidodejobi closed 1 week ago

davidodejobi commented 5 months ago

Description

The alarm sound continues to play in the background even when attempting to select a new sound or exiting the dialog.

Steps to Reproduce:

Click on the FAB (Floating action button) to add a new alarm. Click on the Choose Ringtone button. Click on the play icon button on any of your existing tones.

Expected Behavior: The Upload Ringtone button should verify if a ringtone is currently playing. If no tone is playing, it should proceed to open the folders to select a new tone. If a tone is playing, it should stop the current tone before allowing selection of a new one. Pressing the Done button or closing the dialog should also stop any playing tone.

Actual Behavior: Once a sound starts playing, it continues even after performing this actions

  1. After setting the alarm
  2. When the Done button is pressed
  3. When the dialog is closed
  4. When adding a new sound

Possible Solution: Implement a check before opening the ringtone selection dialog to ensure no tones are currently playing. Additionally, ensure that pressing the "Done" button or closing the dialog stops any playing tones.

Screenshots

CleanShot 2024-03-28 at 06 50 28

davidodejobi commented 5 months ago

@MarkisDev please assign this to me while I work on this