CCGE-BOADICEA / pedigreejs

A web tool for building pedigrees, https://ccge-boadicea.github.io/pedigreejs/
GNU General Public License v3.0
59 stars 42 forks source link

Corrected "status" field representation for accurate depiction of deceased nodes in pedigree diagram. #160

Closed AkshayTripathi0331 closed 6 months ago

AkshayTripathi0331 commented 6 months ago

I'm excited to share this pull request, which introduces an enhancement to our dataset representation across 8 .html files (in /pedigreejs/docs/). The primary focus of this improvement is to refine how the 'status' field is represented within our dataset. Previously, I encountered an issue where the representation of 'status' as a numeric value (e.g., 1) led to inaccuracies in depicting deceased individuals in the pedigree diagram. To address this, I've refined the representation by encapsulating the value within double quotes, resulting in "status": "1".

This refinement ensures a more accurate depiction of deceased nodes in the pedigree diagram, enhancing the overall quality and usability of our system.

Please take a moment to review the corrected representation of a deceased person after changes in example:1 (/pedigreejs/docs/example1.html) in the screenshot below:

After Changes: Screenshot 2024-02-17 145843

Before Changes: Screenshot 2024-02-17 145754

Your thorough review and feedback on this enhancement are highly appreciated.

Thank you for your attention and support!

tcarver commented 6 months ago

Thank you for this and identifying the problem. I have looked at this and I think this commit addresses this now:

https://github.com/CCGE-BOADICEA/pedigreejs/commit/e860cb6