Data name has hard-coded index in dynamixels.py

CCGSRobotics / RoboHUD

The RoboHUD GUI stack developed by CCGS Robotics

https://robohud.readthedocs.io

MIT License

10 stars 4 forks source link

Data name has hard-coded index in dynamixels.py #63

Closed Finchiedev closed 4 years ago

Finchiedev commented 4 years ago

In the file Server/Driving/dynamixels.py, on line 241:

build[line[2]] = {}

If the index of 'Data Name' is anything but that, the code will break. Instead, the index of 'Data Name' should be found by looking through the first line (the header) and setting it to a variable such as data_index. All references to line[2] found in the function (lines 241, 243, 247) should subsequently be replaced with line[data_index].

Finchiedev commented 4 years ago

This has been labelled as good first issue to encourage new contributors to start working on this repository!

frahmadani commented 4 years ago

Hi, can I try working on this one?

Finchiedev commented 4 years ago

Absolutely! Please branch off master and make a pull request when you are done :)

frahmadani commented 4 years ago

Hi @Finchiedev, I've submitted PR #66. I realized I didn't have the csv file to test, so this is only tested with my (assumed) csv. Hope there's nothing I missed :)